Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The LightningEntity class name is inconsistent with the identifier of lightning bolts #3695

Open
haykam821 opened this issue Oct 12, 2023 · 0 comments
Open

The LightningEntity class name is inconsistent with the identifier of lightning bolts #3695

haykam821 opened this issue Oct 12, 2023 · 0 comments
Labels
bug Fixes or discusses a bug within the mappings

Comments

@haykam821
Copy link
Contributor

haykam821 commented Oct 12, 2023 •
edited

The entity associated with lightning is registered under the identifier minecraft:lightning_bolt and is named 'Lightning Bolt'. The class name LightningEntity (and associated names such as LightningEntityRenderer) is inconsistent with these names. The name LightningBoltEntity should be used instead.

yarn/mappings/net/minecraft/entity/LightningEntity.mapping

Line 1 in 669549c

CLASS net/minecraft/class_1538 net/minecraft/entity/LightningEntity

yarn/mappings/net/minecraft/client/render/entity/LightningEntityRenderer.mapping

Line 1 in 669549c

CLASS net/minecraft/class_919 net/minecraft/client/render/entity/LightningEntityRenderer

@haykam821 haykam821 added the bug Fixes or discusses a bug within the mappings label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes or discusses a bug within the mappings
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@haykam821