Renaming ServerScoreboard.objectives, because its purpose is unclear and it can be confused with Scoreboard.objectives

[Papierkorb2292]

Version: 1.20.5-pre4+build.1

Because ServerScoreboard inherits from Scoreboard it can be confusing that both of them have a private objectives field. More importantly, they serve different purposes and I suggest renaming ServerScoreboard.objectives:

The purpose of Scoreboard.objectives is to keep track of all existing objectives known to the server. However, the purpose of ServerScoreboard.objectives is different: This field keeps track of all objectives whose contents should be synced to the client. The .contains checks on that field control whether a ScoreboardObjectiveUpdateS2CPacket should be send and objectives are only added to the field by setObjectiveSlot, when a new objective is set on a slot.

Similarly, I also think the two methods that make the direct modifications to the field should be renamed: ServerScoreboard.addScoreboardObjective and ServerScoreboard.removeScoreboardObjective, since their name currently suggests they would be called every time an objective is added or removed completely, when in reality, they only control which objectives are synced with the client.

As a new name, I suggest something along the lines of visibleObjectives or syncedObjectives.