-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filter seen doesn't work if fields changed #3975
Comments
and this can also be fixed by |
You could either override the plugin priority or disable EDIT: Turns out I misremembered it, priority goes High to Low, not the other way around. |
no, it doesnt working. I use same config1 in issue description, and use this as config 2, torrents are still downloaded, still rejected by seen_info_hash seen:
priority: 10
fields:
- original_url
- title
# - guid |
No it doesn't work indeed... If I execute task with non seen config, then edit config with seen config with fields, seen plugin doesn't work.
I add logger to these 2 plugin
|
NOTE: this doesn't happened in clean state. You must run task without seen config first, then edit config with seen fields to reproduce this bug. |
You want to disable seen_info_hash? You can disable built-in plugins with the disable plugin. disable:
- seen_info_hash Or, you could explicitly configure it as off: seen_info_hash: no Or have I misinterpreted the issue? |
seen plugin doesn't reject task as expected |
Expected behaviour:
seen plugin is expected to reject fetched task.
And I find that, if you update config, it may never remember any task
for example, I have a rss with dynamic torrent url,
<enclosure url="http://127.0.0.1:8745/torrent?q={...}" length="1024" type="application/x-bittorrent"/>
and
{...}
may change, but title and guid never change.So I could have a config look like this:
But
If I change
seen.fields
, the seen plugin just become no-op.for example, from this (config 1):
to this (config 2):
and run it multiple times, it will always pipe this task to
seen_info_hash
, seen plugin never reject this task.Actual behaviour:
seen plugin should reject save
Steps to reproduce:
Log:
(click to expand)
Additional information:
The text was updated successfully, but these errors were encountered: