Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forge app only uses local cache of PlatformSettings data #3847

Open
Tracked by #2782
hardillb opened this issue May 13, 2024 · 2 comments
Open
Tracked by #2782

Forge app only uses local cache of PlatformSettings data #3847

hardillb opened this issue May 13, 2024 · 2 comments
Labels
area:db Database released work bug Something isn't working size:M - 3 Sizing estimation point

Comments

@hardillb
Copy link
Contributor

Current Behavior

When using app.settings.foo = "bar" the API updates the in memory cache then updates the database.

When reading from app.settings.foo it only uses the in memory cache and doesn't refresh from the database.

This will break when we scale the forge app horizontally.

Expected Behavior

Reads from app.settings need to either use a shared cache (redis) or pull from the database on a read.

Steps To Reproduce

Run 2 copies of the forge app with a shared db
update admin settings valuses

Environment

  • FlowFuse version: head/main
  • Node.js version: 18.x
  • npm version: 9.x
  • Platform/OS: Kube/Linux
  • Browser: NA

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

@hardillb hardillb added bug Something isn't working needs-triage Needs looking at to decide what to do size:M - 3 Sizing estimation point area:db Database released work labels May 13, 2024
@hardillb
Copy link
Contributor Author

@knolleary
Copy link
Member

Generally speaking, reading these settings aren't on hot paths, so can afford to be a db lookup.

@joepavitt joepavitt removed the needs-triage Needs looking at to decide what to do label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:db Database released work bug Something isn't working size:M - 3 Sizing estimation point
Projects
Status: Next
Development

No branches or pull requests

3 participants