Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: show if video is saved (and maybe in what playlist) #4982

Open
3 tasks done
MrHappy opened this issue Apr 19, 2024 · 12 comments
Open
3 tasks done

[Feature Request]: show if video is saved (and maybe in what playlist) #4982

MrHappy opened this issue Apr 19, 2024 · 12 comments

Comments

@MrHappy
Copy link

MrHappy commented Apr 19, 2024

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

Now when I watch a video I cannot see if the video is already saved in a playlist (and in what playlist).

Proposed Solution

In the previous version there was a yellow asterisk to indicate it was saved.
Something like that and (preferably the name of the playlist).

Alternatives Considered

Saving it again and after that checking other playlist if I did not save it there already and remove duplicates.

Issue Labels

display more information to user

Additional Information

No response

@jasonhenriquez
Copy link
Collaborator

Can you clarify what change is wanted and where? Like the "Add to Playlist" + icon having a number attached to it? Or some type of change on the prompt where you add the video to different playlists?

@efb4f5ff-1298-471a-8973-3d47447115dc

Hi @MrHappy,

In the previous version there was a yellow asterisk to indicate it was saved.

This isnt gone but it could be that you havent enabled this yet.
Go into one of your playlists and click on the following button

Capture

Now you will see a Clock icon instead of a Star icon on the places you are used to, when hovering on a thumbnail and under the video player.

When clicked on the icon it will save that video to the playlist you have enabled this feature for.

VirtualBoxVM_uxVAdHcxFE.mp4

We also indicate if a video is already added to a playlist

VirtualBoxVM_Ge4sMkAMTQ.mp4

Closing this issue as i think this has addressed your points.

@toby63
Copy link

toby63 commented Apr 23, 2024

@efb4f5ff-1298-471a-8973-3d47447115dc I don't understand why you are against re-implementing a simple indicator to the video page?
I guess that many people see this as a regression.
Instead of seeing it immediately, you have to click on "add to playlist" and then see it in a seperate menu, it is now two steps, where it was one step in the old versions.

@jasonhenriquez I think a number would be useful indeed, but a colored + icon would also be a good start.

@jasonhenriquez
Copy link
Collaborator

jasonhenriquez commented Apr 24, 2024

@efb4f5ff-1298-471a-8973-3d47447115dc I don't understand why you are against re-implementing a simple indicator to the video page?

They didn't say that they were opposed to that; it was more that the issue description didn't specify where the indication was wanted.

I guess that many people see this as a regression.

Is this true since the Favorites playlist is Quick Bookmarked by default, and that's the only playlist users had before v0.20? Having an indicator from the icon of whether the video is in other playlists than the main one is a feature that I'm not sure if I've ever seen in any YT frontend. I'm open to starting the experiment, but I think it would be fair to say this is untrodden ground.

@jasonhenriquez I think a number would be useful indeed, but a colored + icon would also be a good start.

I'm not sure if color alone would be an intuitive indicator of that. Would you be open to creating a sketch or wiremock of your recommendation?

@jasonhenriquez
Copy link
Collaborator

I don't think this is as salient given that the quick bookmark icon resolves this issue for the most common use case of one "main" playlist where people put most videos into, but I will reopen this issue as this seems to be a novel request.

The main question that I have is what use cases we're trying to solve for.

  • Is it that you want to know if there exists a playlist containing this video, even if it's not in the quick bookmark playlist?
    • If so, we could theoretically add some visual identifier to the Add to Playlist icon to represent this.
  • Do you need to know which exact playlists have which video from the icon alone?
    • In which case, we could theoretically have a shortlist of those playlists appear on hover of the "Add to Playlist" icon.
  • Do you want to know the number of playlists that have this video, so that you can use the Add to Playlist prompt to determine your next steps?
    • We could theoretically put a number inside or next to the "Add to Playlist" icon to signify that.

So it would need to be known what is the actual issue that needs to be fixed, and how can it be done in a way that doesn't notably complicate the user experience for people unconcerned with this use case.

@MrHappy
Copy link
Author

MrHappy commented Apr 25, 2024

Hi @MrHappy,

In the previous version there was a yellow asterisk to indicate it was saved.

This isnt gone but it could be that you havent enabled this yet. Go into one of your playlists and click on the following button

Capture

Now you will see a Clock icon instead of a Star icon on the places you are used to, when hovering on a thumbnail and under the video player.

When clicked on the icon it will save that video to the playlist you have enabled this feature for.
VirtualBoxVM_uxVAdHcxFE.mp4

We also indicate if a video is already added to a playlist
VirtualBoxVM_Ge4sMkAMTQ.mp4

Closing this issue as i think this has addressed your points.

I did not have this enabled, but unfortunately this only works for the playlist I marked as 'favorite'.
If I save to a different playlist it does not show anything.

@efb4f5ff-1298-471a-8973-3d47447115dc

but unfortunately this only works for the playlist I marked as 'favorite'.
If I save to a different playlist it does not show anything.

Yes thats the intended behavior. It only shows a checkmark on the thumbnail if it is saved to the quick bookmark playlist.

If you want to know if a video is saved in a playlist that is NOT the quick bookmark playlist you have to go to the add to playlist window for more information.

@toby63
Copy link

toby63 commented Apr 25, 2024

@efb4f5ff-1298-471a-8973-3d47447115dc I don't understand why you are against re-implementing a simple indicator to the video page?

They didn't say that they were opposed to that; it was more that the issue description didn't specify where the indication was wanted.

It seems to me that this is unwanted by @efb4f5ff-1298-471a-8973-3d47447115dc
But that is only my impression.

I guess that many people see this as a regression.

Is this true since the Favorites playlist is Quick Bookmarked by default, and that's the only playlist users had before v0.20? Having an indicator from the icon of whether the video is in other playlists than the main one is a feature that I'm not sure if I've ever seen in any YT frontend. I'm open to starting the experiment, but I think it would be fair to say this is untrodden ground.

One can see it that way (so it is an argument), but I see it a little different: before you could see whether a video was saved and now you can't, at least not immediately.

@jasonhenriquez I think a number would be useful indeed, but a colored + icon would also be a good start.

I'm not sure if color alone would be an intuitive indicator of that. Would you be open to creating a sketch or wiremock of your recommendation?

I am bad at painting, but when I have time, I might experiment with something.
One "problem" is the rather minimalistic icon style that was chosen (which I like in general, don't get me wrong), but the solution would probably need to fit in.
My first thought was simply a colored cross in the icon, for example a blue or green cross.

Regarding the scope:
I think no user would be offended by option 1 (just an indicator that the video is in some playlist).
But option 2 (what playlists) and option 3 (number of playlists) could in theory be unwanted by some users, so should be optional; but are also not required in my oppinion.

@qupear
Copy link

qupear commented May 4, 2024

Is it that you want to know if there exists a playlist containing this video, even if it's not in the quick bookmark playlist?

* If so, we could theoretically add some visual identifier to the Add to Playlist icon to represent this.

This is exactly what is a very wanted feature. Just any indicator that video is any playlist. Speaking about me personally, I don't need any counters here, or name of exact playlist. I use just four themed playlists and I am 100% sure in which playlist a video could be. The only question is a video already saved or not. And currently the only way to find this out is to manually scrolling and remembering. Indicator could be some dot, or color, or frame, or icon.

As workaround this could work. You copy name of video, click plus button to add to playlist and search that title. If nothing found, that means video is not saved.

So my opinion is leave everything as it is, but show an indicator if a video is saved in any playlist. No need to add any functionality. Maybe as an indicator it would be good to use a counter how many times that video occurs in playlits.db file.
Like on this picture.
image
Fortigate video id occurs one time in file playlits.db, comptia video occurs two times. If press on this icon maybe open playlists page. Just as example what could be new feature.

Copy link
Contributor

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.

@MrHappy
Copy link
Author

MrHappy commented May 10, 2024

I was not aware another response was needed. Please reopen.
The option offered by @qupear seems to fit my needs.

@omega3

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

6 participants