Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Transient "hide watched" toggle #4999

Open
3 tasks done
jasonhenriquez opened this issue Apr 22, 2024 · 8 comments
Open
3 tasks done

[Feature Request]: Transient "hide watched" toggle #4999

jasonhenriquez opened this issue Apr 22, 2024 · 8 comments

Comments

@jasonhenriquez
Copy link
Collaborator

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

As a user, I sometimes want to hide watched videos in my subscriptions only sometimes. Rather than have to enable and disable a permanent setting, I would like to be able to do it on a whim and have it revert when it's no longer desired.

Proposed Solution

Implement transient toggle switch somewhere on the Subscriptions page (like the ft-refresh-widget or the top of the page) that overrides the "Hide Videos on Watch" preference until the route is changed.

Alternatives Considered

Have the toggle override the default setting for the session instead of just until route change.

Issue Labels

ease of use improvement, improvement to existing feature

Additional Information

No response

@jasonhenriquez jasonhenriquez added the enhancement New feature or request label Apr 22, 2024
@FreeTubeBot FreeTubeBot added this to To assign in Feature Requests Apr 22, 2024
@jasonhenriquez jasonhenriquez moved this from To assign to Low Priority in Feature Requests Apr 22, 2024
@jasonhenriquez jasonhenriquez added the good first issue Good for newcomers label Apr 22, 2024
@ankitchauhan-aka
Copy link

Can I work on this!

@jasonhenriquez
Copy link
Collaborator Author

Thanks for your enthusiasm @ankitchauhan-aka! Let me first invite the other contributors to provide their feedback on if and how we want this feature look. CC: @efb4f5ff-1298-471a-8973-3d47447115dc @absidue @ChunkyProgrammer @PikachuEXE @MarmadileManteater

@MarmadileManteater
Copy link
Contributor

My opinion is that we should try to limit the number of floating transient things on the page, but I understand the desire for this feature because the current Hide Watched setting is not reactive as-is.

@jasonhenriquez
Copy link
Collaborator Author

I agree with both of those sentiments. Part of my mindset is that I would never really want to have "Hide Videos on Watch" enabled permanently, but I would like to be able to toggle it on/off at will when looking at my open subscription videos. I sometimes will open a video and want to go back to it when I see it on my feed, so I wouldn't want it always be on. You could also make a similar but less salient case for "Only Show Latest Video for Each Channel". I wonder if something like an icon checkbox dropdown from #4231 would work for this.

@ChunkyProgrammer
Copy link
Member

Maybe we could have a "Show Hidden results" link/button that appears if there's anything that's hidden (this can apply to subscriptions and searching if you have blocked any channels/tags). There should also probably be a parental control to prevent that link/button from showing though (on the search page at least)

@jasonhenriquez
Copy link
Collaborator Author

That's an interesting idea, I like that. Maybe that setting is a dropdown if we want to distinguish among "Hide 'Show hidden' button", "Always hide blocked words and channels", and "Default"? Or maybe just a toggle for MVP.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Just to be clear this issue isnt part of these issues: #4412 and #1077 ?

@jasonhenriquez
Copy link
Collaborator Author

Removing "good first issue" for now as the exact design is still somewhat in the air.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Feature Requests
Low Priority
Development

No branches or pull requests

5 participants