fix: flaky TransactionResponse test
#2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedsalk
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10,
danielbate,
petertonysmith94 and
maschad
as code owners
Torres-ssf
approved these changes
May 8, 2024
|
Coverage Report:
Changed Files:
|
maschad
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I retried the test 100s of times locally and could not get it to fail. My hunch is that it's because of the CI environment being slow.
I increased the
--tx-pool-ttlto 1 second to allow for some more room before the transaction is squeezed out and--poa-interval-periodto 4s to ensure that the transaction doesn't get processed before it's squeezed out. Still, these are just informed shots in the dark; I don't know the underlying root cause.Due to the flakiness of the test and me not knowing the root cause, I also added
{ retry: 10 }to it so that it's retried if it fails. This should at least reduce the flakiness a lot if the changes to the flag values aren't enough.Also note that this is the way to test the squeezing out of a transaction and I was given guidance by the
fuel-coreteam on how to write it.closes #2200