Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cleanup typedoc for Account and Wallet #2276

Merged
merged 19 commits into from
May 23, 2024
Merged

chore: cleanup typedoc for Account and Wallet #2276

merged 19 commits into from
May 23, 2024

Conversation

danielbate
Copy link
Contributor

Closes #2249

@danielbate danielbate self-assigned this May 9, 2024
maschad
maschad requested changes May 9, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling correction but looks good otherwise.

packages/account/src/account.ts Outdated Show resolved Hide resolved
danielbate and others added 2 commits May 10, 2024 14:29
@danielbate danielbate requested a review from maschad May 10, 2024 07:52
@danielbate danielbate marked this pull request as draft May 10, 2024 11:05
@danielbate danielbate marked this pull request as ready for review May 12, 2024 06:55
petertonysmith94
petertonysmith94 reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple similar issues as the example that I've raised in these two classes... I have suggested all of them but happy to run though them with you 😄

packages/account/src/providers/provider.ts Outdated Show resolved Hide resolved
packages/account/src/providers/provider.ts Outdated Show resolved Hide resolved
packages/account/src/providers/provider.ts Show resolved Hide resolved
@danielbate @petertonysmith94
docs: update doc
960d715 
Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
maschad
maschad previously approved these changes May 13, 2024
View reviewed changes
Torres-ssf
Torres-ssf previously approved these changes May 14, 2024
View reviewed changes
arboleya
arboleya previously approved these changes May 14, 2024
View reviewed changes
@arboleya
Copy link
Member

@danielbate :shipit: ?

petertonysmith94
petertonysmith94 previously approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Torres-ssf
Torres-ssf requested changes May 23, 2024
View reviewed changes
Copy link
Contributor

@Torres-ssf Torres-ssf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍

packages/account/src/account.ts Outdated Show resolved Hide resolved
packages/account/src/providers/provider.ts Show resolved Hide resolved
@danielbate @Torres-ssf
docs: update typedoc
f43406c 
Co-authored-by: Sérgio Torres <30977845+Torres-ssf@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.76%(+0%) 70.69%(+0%) 76.86%(+0%) 79.85%(+0%)
Changed Files:

Coverage values did not change👌.

petertonysmith94
petertonysmith94 approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@danielbate danielbate merged commit 395eb2c into master May 23, 2024
19 checks passed
@danielbate danielbate deleted the db/chore/typedoc-cleanup-wallet-account branch May 23, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@danielbate danielbate

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review outdated Typedocs
5 participants
@danielbate @arboleya @maschad @petertonysmith94 @Torres-ssf