Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect asset for devnet #2281

Open
petertonysmith94 opened this issue May 9, 2024 · 10 comments · May be fixed by #2432
Open

Incorrect asset for devnet #2281

petertonysmith94 opened this issue May 9, 2024 · 10 comments · May be fixed by #2432
Assignees
Labels

Comments

@petertonysmith94
Copy link
Contributor

petertonysmith94 commented May 9, 2024

We export assets that can be easily consumed by the end user.

  • The assetId is currently 0x0000…. (or baseAssetId), is incorrect for devnet and testnet.

    • Expected: 0xf8f8b6283d7fa5b672b530cbb84fcccb4ff8dc40f8176ef4544ddb1f1952ad07
  • The chainId for devnet should be 0.

Reported by @LuizAsFight

@LuizAsFight
Copy link
Contributor

I think beta5 can be removed and devnet changed to zero. as we will drop support to beta5 when devnet gets released

@LuizAsFight
Copy link
Contributor

about the baseAssetId its a bigger problem
my first thought for this:

  • the static definition assets should not be exported anymore. create a isBaseAsset flag, so we don’t need to inform the address for the base assets, and can identify it later on next topic
  • create a getAssets which receives the provider and sort out the correct baseAssetIds to the assets that are needed. also it can filter out the assets that are not from the provider chainId

@Torres-ssf
Copy link
Contributor

@LuizAsFight Why we should remove the static assets?

I reckon that the baseAssetId is not something that's going to change on Test-net/Main-net.

@arboleya
Copy link
Member

@Torres-ssf Do you know why baseAssetId became dynamic?

@LuizAsFight
Copy link
Contributor

@LuizAsFight Why we should remove the static assets?

I reckon that the baseAssetId is not something that's going to change on Test-net/Main-net.

@Torres-ssf its not to remove static assets, instead its to keep it, but remove only the specific mocked asset ids 0x00000...

a quickfix would be to just replace the assetId from testnet eth to be "0xf8f8b6283d7fa5b672b530cbb84fcccb4ff8dc40f8176ef4544ddb1f1952ad07"

@LuizAsFight
Copy link
Contributor

ref #2394

@arboleya
Copy link
Member

@xgreenx @LuizAsFight As we briefly discussed last week, should we use a hardcoded assetId value in the JSON for now and re-think the approach if/when the situation changes?

@petertonysmith94
Copy link
Contributor Author

Should add a new entry for testnet - or renamed devnet?

@xgreenx
Copy link

xgreenx commented Jun 3, 2024

We should add a new entry

@xgreenx
Copy link

xgreenx commented Jun 3, 2024

@xgreenx @LuizAsFight As we briefly discussed last week, should we use a hardcoded assetId value in the JSON for now and re-think the approach if/when the situation changes?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants