Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Tags JOIN #512

Open
Dookoen opened this issue Apr 23, 2024 · 7 comments
Open

[Feature Request] Tags JOIN #512

Dookoen opened this issue Apr 23, 2024 · 7 comments
Labels
feature-request New feature request

Comments

@Dookoen
Copy link

Dookoen commented Apr 23, 2024

Describe your feature request
Is it simple to implement a tags JOIN operation? For instance, when I keep pressing a certain key (such as 'command'), I click on 'tag1' and 'tag2' (and possibly more), then Paperlib shows all papers that contain both 'tag1' and 'tag2'. I think this way is more convenient compared to using smart filters. There may be multiple combinations for these JOINs, and managing a massive amount of smart filters may be difficult.

@Dookoen Dookoen added the feature-request New feature request label Apr 23, 2024
@GeoffreyChen777
Copy link
Member

have you tried the advanced searching?

ALL {'tag1', 'tag2'} IN tags.name

@Dookoen
Copy link
Author

Dookoen commented Apr 23, 2024

Hello! Yes, I have tried it before this issue. Paperlib is a paper manager with a nice modern UI. Users might not want to use it in a CLI manner for some simple functions, especially those who are not CS majors.

@GeoffreyChen777
Copy link
Member

OK, it's doable. I think it's not very hard.

However, recently I've been a little busy with my own research. If you could contribute to this feature, I can give you some suggestions about this.

@Dookoen
Copy link
Author

Dookoen commented Apr 23, 2024

Yes, i think it is not complicated and i can contribute to this. I just need some time to clarify the code architecture.

@GeoffreyChen777
Copy link
Member

I would suggest you starting from here:

const onSelect = (payload: { _id: string; query: string }) => {

That’s what will happen when a user clicks a tag/folder.

@Dookoen
Copy link
Author

Dookoen commented Apr 23, 2024

Thanks, i will take a look and figure it out.

@GeoffreyChen777
Copy link
Member

Hi @Dookoen , are you still working on this? Do you need any help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature request
Projects
None yet
Development

No branches or pull requests

2 participants