Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full screen modal for image gallery grid in overlay #1370

Closed
vishalnarkhede opened this issue May 17, 2022 · 2 comments
Closed

Full screen modal for image gallery grid in overlay #1370

vishalnarkhede opened this issue May 17, 2022 · 2 comments
Labels
Enhancement New feature or request Good First Issue Good for newcomers Internal Backlog Moved to our internal backlog User Experience

Comments

@vishalnarkhede
Copy link
Contributor

vishalnarkhede commented May 17, 2022

Motivation

As per our current implementation, image grid opens as a modal on top of image viewer. But it has no explicit backdrop, which creates a confusion between the header of image grid and underlying image viewer. Especially the close buttons for image viewer vs close button for image grid modal. We should improve the experience for user around this feature.

Screenshot 2022-05-17 at 09 56 31

Proposed solution

Update the snap points for image grid modal so that it covers the entire screen.

https://github.com/GetStream/stream-chat-react-native/blob/develop/package/src/components/ImageGallery/ImageGallery.tsx#L178

NOTE: Following code is just an idea, please don't copy-paste it for the fix

const { top } = useSafeAreaInsets();
const snapPoints = React.useMemo(() => ([Dimensions.get('window').height - top]), [])

Screenshot 2022-05-17 at 09 57 51

@vanGalilea vanGalilea added the Good First Issue Good for newcomers label May 20, 2022
@vanGalilea
Copy link
Contributor

@vishalnarkhede vishalnarkhede added the Internal Backlog Moved to our internal backlog label Sep 21, 2023
@khushal87
Copy link
Member

khushal87 commented May 22, 2024

Hey @vishalnarkhede this is the current behaviour from what I see. We improved this behavaiour and logic of snap points in #2490 and this seems to eliminate this issue when the picker is fully draged to top. I hope this is(the video below) what is expected, right?

Simulator.Screen.Recording.-.iPhone.14.-.2024-05-22.at.12.23.31.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Good First Issue Good for newcomers Internal Backlog Moved to our internal backlog User Experience
Projects
None yet
Development

No branches or pull requests

3 participants