Allow continue on download retries #185
Conversation
| @@ -183,6 +183,7 @@ function download_component() { | |||
| show_message "downloading $4 ..." | |||
| ariapkg=$(package_installed aria2c "summary") | |||
| curlpkg=$(package_installed curl "summary") | |||
There was a problem hiding this comment.
I think we can opt out of curl, so remove any lines which use curl, such as this
| show_message "using wget to download $4" | ||
| wget --no-check-certificate "$3" -P "$CACHE_PATH" | ||
| wget --no-check-certificate "$3" --continue --tries=0 -P "$CACHE_PATH" | ||
| else |
There was a problem hiding this comment.
and in else block we can print error with sugestion to install aria/wget and retry
|
To be fair with curl, I have not tested aria2 (thus the no edit). Maybe the curl command can benefit from a little warning message, if the file download link continue to be not very stable. Anyway, I just want to propose the allow-continue behavior since it's readily available in at least wget. |
|
And because of this you must opt out of curl |
|
This solution is fixing this bug. I succesfully downloaded photoshopCC-V19.1.6-2018x64.tgz from |
This patch tries to resolve #175 , #167 , #150 (and alikes if they exist). The server (victor.poshtiban.io) drops connection(?) every 200Mb or so, making curl to fail with "HTTP/2 stream 0 was not closed cleanly: INTERNAL_ERROR (err 2)".
Existing suggestions either need custom script, or at least require the user to download and move the file. It seems unnecessary. I propose to retry & continue in-place with
wget, which should be available on most linux systems.The
curlcommand was also modified to allow retry and continue, but it won't go through that particular error. I'm not familiar with curl, sorry. I think it should be able to, but can't find the right solution.