core(types): add missing fields to Result.Category and NodeDetails
#16006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
2 tasks
angad-sethi
changed the title
Result.Category and NodeDetailsResult.Category and NodeDetails
angad-sethi
changed the title
Result.Category and NodeDetailsResult.Category and NodeDetails
connorjclark
approved these changes
May 21, 2024
connorjclark
changed the title
Result.Category and NodeDetailsResult.Category and NodeDetails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #15799.
Summary
supportedModeshas been added toResult.Categorysince it is being emitted as a part of the generated results.explanationhas been added toArtifacts.NodeDetailssince it is being set inaxe-audit.js(line 79).I've added them in as optional types, please let me know if that is incorrect. Cheers!
Related Issues/PRs
Related Issue - #15799