Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage/objects: TestObjects failed #3565

Closed
flaky-bot bot opened this issue Nov 11, 2023 · 5 comments · Fixed by #4000
Closed

storage/objects: TestObjects failed #3565

flaky-bot bot opened this issue Nov 11, 2023 · 5 comments · Fixed by #4000
Assignees
Labels
api: storage Issues related to the Cloud Storage API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Nov 11, 2023

Note: #2885 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.


commit: f2e5277
buildURL: Build Status, Sponge
status: failed

@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Nov 11, 2023
@product-auto-label product-auto-label bot added api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. labels Nov 11, 2023
@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Nov 12, 2023
Copy link
Author

flaky-bot bot commented Nov 12, 2023

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


When run at the same commit (f2e5277), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@tritone
Copy link
Contributor

tritone commented Jan 17, 2024

Error:

    objects_test.go:148: downloadUsingRequesterPays: Object("foo.txt").NewReader: storage: object doesn't exist

Based on the test I don't really see how this flake should be possible as a standalone, given that the object is also queried in the previous lines. Maybe some subtlety with requester pays; @BrennaEpp can you take this?

@tritone tritone assigned BrennaEpp and unassigned tritone Jan 17, 2024
@BrennaEpp
Copy link
Contributor

I'll take a look

@BrennaEpp
Copy link
Contributor

This is weird...

  • There are no metadata updates to cause errors with delayed propagation, and as @tritone mentions, this object is used before (and after) in the test without failure.
  • It's using the same project that owns the bucket for billing, so there really shouldn't be any permission issues.
  • The upload is done using preconditions so it should be idempotent (and in any case it should error if it fails to upload).
  • I don't see any operations that would cause side effects causing flakiness, but it's hard to tell since there is so much going on and different buckets being interspersed in the test.

I think what I'm going to do here is separate out this part of the test which will make it obvious that nothing else is going on if it fails again.

@BrennaEpp BrennaEpp added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 8, 2024
@BrennaEpp
Copy link
Contributor

Bumping down priority as the issue is not related to requesterpays and requires instead some changes to testutil instead (these are in progress).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@tritone @BrennaEpp and others