Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Borders missing after dropping components over it #338

Open
gustavohleal opened this issue Oct 24, 2023 · 0 comments
Open

BUG: Borders missing after dropping components over it #338

gustavohleal opened this issue Oct 24, 2023 · 0 comments

Comments

@gustavohleal
Copy link
Contributor

Hi!

We have found this bug that is removing the border from columns when you drop components into it specifically over the border drawing even with the sorter indicating the right place. The strangest thing is that it only removes the border from the view. If you open the styles panel the values are still there and if you change anything it will re-render and it works again. And if you open the export-code modal or check the view by inspecting the elements it still has the border attributes as mjml standards.

All of this was tested in the demo and only happens in the mjml editor.

Here is the expected behavior. The block dragged is being dropped in the center of the column and then added normally.

Screencast.from.23-10-2023.11.38.36.webm

But here is the current behavior. The block is being dragged over the column but is dropped over the border itself. The sorter is still indicating the bottom of the column the way it was suppose to. In this case i added border-radius so it is possible to see that after the border disappears the radius is still there. Then I changed 1px in the border-width and the border comes back as it was.

Screencast.from.23-10-2023.11.40.14.webm

I have put debuggers in every function of the core and column model and view to see what was being triggered. Checked sorter and canvas events to see if it was getting some target wrong and nothing. I'm current trying to pass over the entire drop component cycle from grapes but still with no success.

If someone has any ideas or directions for where to keep debugging in the grapes cycle from the moment it drag over, drop the component to the moment it is rendered i would appreciate the help.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant