New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transform node crashes app when scale == 0 #1635
Comments
issue only seems to occur when a TransformNode -> RepeatNode... |
any updates? |
There are several upcoming refactors so this issue is being put aside for now. |
Yeah, it's potentially blocked by @TrueDoctor's work on #1558 |
As far as I can tell (please include the actual panic message in future) this is probably from failing to inverse a transform matrix containing 0 in debug mode? We likely need to special case the zero transform such that we don't end up inverting. @Keavon / @Kakapio I struggle to see how this is relevant to a change in the pivot code. |
Thanks for chiming in @0HyperCube, perhaps this doesn't need to be blocked then (it just needs to have a zeroness check in the correct place, like where you suggested with the inverse transform matrix). |
Here's the full output, I think. This should be the correct log. But yes, will look into this some more. |
This is primarily an issue when dragging the scale parameters to adjust them in the UI. When the value for scale hits 0 on either x or y, Graphite crashes. I'm gonna look into this myself and try to patch it up (since I'm new 馃槃) but I'm making an issue to document it.
My solution is to just ignore an input of 0 in the backend. Let me know if that's too sloppy.
The text was updated successfully, but these errors were encountered: