Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari rendering bug causes upward offset of tool shelf color picker #1687

Open
Keavon opened this issue Mar 14, 2024 · 1 comment
Open

Safari rendering bug causes upward offset of tool shelf color picker #1687

Keavon opened this issue Mar 14, 2024 · 1 comment
Labels
Bug Something isn't working Dependencies Pull requests that update a dependency file Help Wanted Extra attention is needed Web Involves web programming (TypeScript, Vue, CSS)

Comments

@Keavon
Copy link
Member

Keavon commented Mar 14, 2024

There is a Safari bug affecting our color picker popover for the tool shelf's working colors input. It causes Safari to render the popover by about a 130px upward offset. However, the click targets and devtools hover highlight visualizations for the elements in this popover do show up in the correct location, so this only affects how Safari paints the content.

capture_11_.mp4
  • It only occurs if there exists a scrollbar in the Properties panel
    • But strangely, it doesn't happen if there exists a scrollbar in the Layers panel— something must somehow be different between those two panels
  • It only occurs if the tool shelf has at least two columns
    • However, it being two or three columns doesn't affect how tall the ~130px upward offset is
    • Deleting the .tools container will visibly shrink the shelf back to a width of 1 column, but doesn't stop the issue from occurring until the web page gets resized
  • Disabling container-type: size; on the .shelf-and-table element prevents the issue from occurring

We need to investigate this further, ideally create a minimal reproduction test case, and report this. Then hope it's fixed. Or, find a particular way that we can change things to mitigate this on our end.

This is tested on Safari 16.5. container-type was added in Safari 16 (released 2022-09-12).

@Keavon Keavon added Bug Something isn't working Help Wanted Extra attention is needed Dependencies Pull requests that update a dependency file Web Involves web programming (TypeScript, Vue, CSS) labels Mar 14, 2024
@Keavon
Copy link
Member Author

Keavon commented Mar 14, 2024

Maybe related, as this is the only webkit bug report I can find about container-type: https://bugs.webkit.org/show_bug.cgi?id=256047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Dependencies Pull requests that update a dependency file Help Wanted Extra attention is needed Web Involves web programming (TypeScript, Vue, CSS)
Projects
Status: Short-Term
Development

No branches or pull requests

1 participant