Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IPinfo MMDB database format #533

Open
GyulyVGC opened this issue May 10, 2024 · 3 comments
Open

Support IPinfo MMDB database format #533

GyulyVGC opened this issue May 10, 2024 · 3 comments
Assignees
Labels
bug Something isn't working enhancement New feature, request, or improvement
Milestone

Comments

@GyulyVGC
Copy link
Owner

GyulyVGC commented May 10, 2024

What's the problem?

In version 1.3.0 I introduced the possibility to select custom MMDB databases for country and ASN resolutions (you can find out more about it here).

However, I noticed that IPinfo (one of the best IP data providers globally) uses a slight different format for such databases, which is currently unsupported by Sniffnet (because the application expects databases to be in the canonical MMDB format).

Additional context

The goal is to support both the canonical format and IPinfo's custom MMDB format, so that users of the app will be able to select IPinfo high quality databases.

If you are interested about why IPinfo uses a different format, I suggest you to read this article.

I also want to thank a lot @abdullahdevrel who gave me amazing insights about this topic and wrote a detailed community post about how to interface with IPinfo's MMDBs in Rust.

Related issue: oschwald/maxminddb-rust#82

@GyulyVGC GyulyVGC added bug Something isn't working enhancement New feature, request, or improvement labels May 10, 2024
@GyulyVGC GyulyVGC added this to the v1.3.1 milestone May 10, 2024
@GyulyVGC GyulyVGC self-assigned this May 10, 2024
@GyulyVGC
Copy link
Owner Author

@all-contributors please add @abdullahdevrel for ideas, content.

Copy link
Contributor

@GyulyVGC

I've put up a pull request to add @abdullahdevrel! 🎉

@abdullahdevrel
Copy link

Thank you very much, @GyulyVGC. It is IPinfo's pleasure to be a part of such important OSS software that keeps the internet safe and secure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature, request, or improvement
Projects
None yet
Development

No branches or pull requests

2 participants