-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.8.0 release planning #5958
Comments
Can we also merge #4384 ? I use it regularly. I think @bradleysepos was satisfied with my selection logic. It can be later tweaked if we find corner cases, but I think it's good as it is. ☑️ Done |
This also would be really nice to have #5922 ☑️ Done |
And hopefully I can look into this issue before release #5948 ☑️ Done |
I believe so after re-reading the PR. Though I cannot recall testing it directly, I trust it does what you say it does. |
I can make PRs to update all translations, once it is sure that no more new strings will go into 1.8.0. |
Probably a good idea to make a note that this is coming on transifex again. |
Would somebody be able to update ☑️ Done |
I did so. |
Maybe update harfbuzz to 8.4.0 ? #5965 |
I'm not sure how this is meant to be run. I attempted:
And this generated a new
So I must be missing an option or configuration somewhere. |
Oh, I just edited the year in myself. I don't think there's any way to set the year (or other variables) with xgettext, they're just supposed to be manually added to the .po files by the translators. |
What about updating the Flatpak runtime to Gnome 46? It builds fine, just need to check that encoding is working. |
Yes please. |
Shall we code freeze soon ? :) |
Whenever you say is fine by me. I've just been picking some low hanging fruit from our issues list to fix. I can stop at any time 😰 (says the addict). |
Pretend I said nothing ;) |
Thanks for merging all the localization PRs. This will give the localizers the opportunity to check how the strings look in the UI. I have noticed there is still some activity ongoing for at least one or two locales to finish the remaining strings, so I plan to do PRs for this new strings beginning or middle of next week (if thats OK). |
Sounds good. |
Is anything missing from the news? |
Looks like we got the bulk of it. Maybe if @bradleysepos has some time to review too? |
I should be able to make some time this week. |
There are some new (unapproved) patches for x265 regarding AArch64. I am not an expert in this, but at least this two might be useful for us? |
FYI, I'm traveling until next Monday. My time will be limited until then. |
@Nomis101 the first looks like only for arm64e, but we compile for the normal arm64 arch, the second probably should be useful, but maybe we can integrate the whole set after they merge it, in the next minor release. SVT-AV1 2.1 should be out in a week or so, let's wait a bit so we don't ship with an out of date version. |
Thanks for looking into it. This is of course also a good idea. It might just take a while until there is a new x265 release, 3.6 has been 3 years in the making. |
Sorry folks,
Seems this is regression since we have not contribute anything since 1.7.3 release. I will try to know more details tomorrow. @sr55 any thoughts? |
Found breaking change 069b785 Reproducible only via GUI @galad87 are you able to reproduce the crash? Preview function was modified 4366cd3#diff-574ebf6c5d95e912886b84976f946f09a74d7c04c72be275182bafff202f14eaR920 |
I don't any have QSV hardware ready to use at the moment. I wonder if it's trying to use vpp in the preview format filter for some reason? It would be useful to see where it's crashing in libhb. |
Does it happen with a specific source file or with everything? |
I'll try reproduce it shortly to and see if I can't get a stack trace |
Confirmed. It happens specifically when QSV decode is turned on. No Crash if QSV decode is disabled in preferences. |
No joy with GDB :( |
It would be nice to switch to the clang toolchain to be able to debug libhb inside visual studio. |
I've disabled all hardware decoding during previews (including other vendors). Builds running. Lets see if this helps. If I disable static previews on the screen in the mean time, it appears to work, fill path, hyperencode enabled so it looks like the encode path is fine. |
yes, it is challenging to get underlying hb.dll call stack |
The new build works fine. No crashes have been observed. Thanks for the fix. |
Another issue, not related to QSV, has been found On some machines, not everywhere, I see connecting issue to the Worker process. Disabling process isolation fixes the issue.
|
I've pushed another build with some debug logging. Two most likely possibilities is security software / firewall interfering with it or potentially a broken system dll file. Hopefully the new logging will give us a hint. Snapshot builds running now. |
I have tested new build. No detailed logs appear.
|
There is an idle shutdown in the worker, but it won't activate until the GUI connects. I guess I may need to extend that to shutdown if we don't get a connection after a minute or so. |
I've added more logging since it appears to be a non-fatal error that's occurring which blows my theories out the water I suspect. I've also hopefully fixed the stale process issue. New snapshot will be available in about an hour. |
Stale process is fixed. The detailed log is available now.
|
Yup, it's some kind of firewall/network/VPN appliance on your end. It's Man in the Middling the connection between the UI process and the Worker. It's pretty aggressive network filtering to block localhost loopback. All you can do in these cases is turn off process isolation unless your corporate security team can add an exception. |
@sr55 thanks for confirmation that this is not HandBrake issue. In meantime, I will clarify machine configuration details. |
There are some fairly large updated contribs that would be nice to have in an official release, plus the GTK4 GUI, hopefully in a few weeks.
Here's a (probably incomplete) list of major things still missing:
@Nomis101 @robxnano @sr55 @bradleysepos @jstebbins @hnsteyding
The text was updated successfully, but these errors were encountered: