Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual OpenAI async code vs official AsyncOpenAI #100

Open
chemeris opened this issue Apr 27, 2024 · 3 comments
Open

Manual OpenAI async code vs official AsyncOpenAI #100

chemeris opened this issue Apr 27, 2024 · 3 comments

Comments

@chemeris
Copy link

I noticed that you're making async calls to OpenAI API manually in async def async_create_completion(). Is there any reason for this instead of using the AsyncOpenAI from the official library?

The reason I found this is because I was instrumenting our app with OpenTelemetry and OpenLLMetry just to find that async OpenAI calls from Adala are not instrumented - because OpenLLMetry expects standard openai package calls. It would be great to stick to the official package to make this (and other) useful tricks working.

@chemeris
Copy link
Author

Hi, still looking for a response

@matt-bernstein
Copy link
Contributor

Hi, thanks for reaching out! Happy to say this is under development in #120 and should be merged in next week. Interested to hear more about your use case if you have details to share.

@chemeris
Copy link
Author

Thank you. This is great to hear!
I hope it'll make it easier for us to use LangFuse or something similar as we move towards more instrumentation and observability for our production environment.

PS I'm happy to share our use cases privately, as we're working on an internal proprietary tool.
I would also appreciate it if our (very simple) bugfixes are merged (or fixed otherwise) - like this one: #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants