Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Add item "Preview PDF" to Options menu and show in a modal window #925

Open
Verony-makesIT opened this issue Feb 11, 2023 · 5 comments · May be fixed by #944
Open

[Feature Request] Add item "Preview PDF" to Options menu and show in a modal window #925

Verony-makesIT opened this issue Feb 11, 2023 · 5 comments · May be fixed by #944
Labels
Feature Request Improvement or Feature Request
Milestone
1.7 beyond

Comments

@Verony-makesIT
Copy link
Contributor

In several places (in Quotes and Invoices, among others) you can find the "Options" dropdown menu.
Here you can select the menu item "Download PDF." The application then jumps to a new tab window and the corresponding Quote or Invoice pdf is displayed.

Expected Behavior

Choose the menu item "View PDF" which opens a modal window (with the PDF) on top of the current page

Current Behavior

Menu item "Download PDF" opens a new tab window, jump to it and show the PDF there

Screenshots

image

Possible Solution

Replace the behavior of "Download PDF" with "View PDF" and show PDFs anywhere in the application in a modal window

Context (Environment)

Each time you click on this menu item, a new tab window will open where the pdf is displayed.
This is very confusing and you may have multiple tab windows open with different pdf versions of the same Quote or Invoice as a result.
@gaelicwinter
Copy link

gaelicwinter commented Feb 11, 2023 via email

@clockwiseq
Copy link
Contributor

I have to agree with @gaelicwinter. I believe the current functionality suffices and maybe we need to add a second button for "preview" and that would perform the action @Verony-makesIT has described above.

@Verony-makesIT
Copy link
Contributor Author

If I follow @gaelicwinter procedure he performs following steps:

  1. choose menu item "Download PDF"
  2. view pdf in open tab
  3. switch back to IP quote/invoice
  4. make adjustments
  5. switch back to the tab
  6. refresh tab and view adjustment
  7. close tab if everything is ok
  8. switch back to the IP tab

My suggestion:

  1. choose menu item "View PDF"
  2. view pdf in open modal window
  3. click to close this modal window
  4. make adjustments
  5. select menu item and view modification
  6. close modal window if everything is ok

Conclusion:
To do the same thing, in my proposal there are actually 2 fewer steps to perform and you keep working on the same web page. For many people, this will feel more natural and be more pleasant to work with.
I created this because it is precisely difficult for me to do this the "IP way".

Can't we leave the choice to the user which option they want to use by adding an additional setting [Download PDF in tab] or [View PDF in modal]?

@nielsdrost7
Copy link
Contributor

My 2 cents:
Open "Download PDF", it will open in new tab.
Switch back to old tab
Move new tab to a "new window"
Place the windows side-by-side
Adjust on 1 side an view on the other side.
No need to change anything ... yet.

Don't delete options, but add new ones: View PDF, or like clockwiseq said: Preview PDF, that one can open in a modal.
Getting those PDFS to view correctly in some browsers is a terrible task, stay away from it, is what I would say.

To test the behaviour, don't rely on your own PC, there's an application called 'Browserstack' which will prepare your windows types, Mac types and several exotic browsers

@Verony-makesIT
Copy link
Contributor Author

I think there is a misunderstanding somewhere.
My intention is not to remove or replace an option but to give the user a choice between the visibility of the 2 options via a setting in IP.
Example:

  • By default the setting is off and only the menu choice "Download PDF" is visible.
  • If the setting is on then the menu choice "Preview PDF" is (additionally?) visible in the 'Options menus'.

Regarding your comment about viewing pdfs in the browser, I just want to point out that I do not want to introduce new techniques in IP but only use the same modal functionality that is present in IP since years. E.g. modal create invoice, add_invoice_tax, etc.. So nothing new, just instead of some text and form fields I show the pdfs in an iframe in the body of the modal. The pdfs are rendered with their own internal pdf browser engine.
I don't think that should be a problem for any browser.

@Verony-makesIT Verony-makesIT changed the title [Feature Request] Replace the behavior of "Download PDF" with "View PDF" in a modal window [Feature Request] Add item "Preview PDF" to Options menu and show in a modal window Feb 13, 2023
Verony-makesIT added a commit to Verony-makesIT/InvoicePlane that referenced this issue Apr 13, 2023
@Verony-makesIT
Merge branch 'InvoicePlane:development' into Preview-PDF-in-Modal-Inv…
f6ca2df 
…oicePlane#925
@Verony-makesIT Verony-makesIT linked a pull request Apr 14, 2023 that will close this issue
Draft
7 tasks
@clockwiseq clockwiseq linked a pull request Apr 14, 2023 that will close this issue
[IP-925]: Preview pdf in modal #944
Draft
7 tasks
Verony-makesIT added a commit to Verony-makesIT/InvoicePlane that referenced this issue Apr 29, 2023
@Verony-makesIT
Revert "Merge branch 'InvoicePlane:development' into Preview-PDF-in-M…
87ddcc6 
…odal-InvoicePlane#925"

This reverts commit f6ca2df, reversing
changes made to 70bac8c.
Verony-makesIT added a commit to Verony-makesIT/InvoicePlane that referenced this issue Apr 29, 2023
@Verony-makesIT
Revert "Revert "Merge branch 'InvoicePlane:development' into Preview-…
4efd71a 
…PDF-in-Modal-InvoicePlane#925""

This reverts commit 87ddcc6.
@nielsdrost7 nielsdrost7 added the Feature Request Improvement or Feature Request label Aug 5, 2023
Verony-makesIT added a commit to Verony-makesIT/InvoicePlane that referenced this issue Aug 11, 2023
@Verony-makesIT
Merge branch 'InvoicePlane:development' into Preview-PDF-in-Modal-Inv…
6571479 
…oicePlane#925
Verony-makesIT added a commit to Verony-makesIT/InvoicePlane that referenced this issue Nov 15, 2023
@Verony-makesIT
Merge branch 'InvoicePlane:development' into Preview-PDF-in-Modal-Inv…
3aed7de 
…oicePlane#925
Verony-makesIT added a commit to Verony-makesIT/InvoicePlane that referenced this issue Dec 5, 2023
@Verony-makesIT
Merge branch 'InvoicePlane:development' into Preview-PDF-in-Modal-Inv…
90a08a7 
…oicePlane#925
@nielsdrost7 nielsdrost7 modified the milestones: 1.6.2, 1.7 beyond Dec 23, 2023
Verony-makesIT added a commit to Verony-makesIT/InvoicePlane that referenced this issue Dec 24, 2023
@Verony-makesIT
Merge branch 'InvoicePlane:development' into Preview-PDF-in-Modal-Inv…
092f556 
…oicePlane#925
Verony-makesIT added a commit to Verony-makesIT/InvoicePlane that referenced this issue Jan 13, 2024
@Verony-makesIT
Merge branch 'InvoicePlane:development' into Preview-PDF-in-Modal-Inv…
34f0041 
…oicePlane#925
Verony-makesIT added a commit to Verony-makesIT/InvoicePlane that referenced this issue May 16, 2024
@Verony-makesIT
Merge branch 'InvoicePlane:development' into Preview-PDF-in-Modal-Inv…
1179a4e 
…oicePlane#925
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request Improvement or Feature Request
Projects
None yet
Milestone
1.7 beyond
Development

Successfully merging a pull request may close this issue.

[IP-925]: Preview pdf in modal Verony-makesIT/InvoicePlane
4 participants
@gaelicwinter @clockwiseq @Verony-makesIT @nielsdrost7