Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lots of Bugfixes #2960

Merged
merged 60 commits into from
May 22, 2024
Merged

Lots of Bugfixes #2960

merged 60 commits into from
May 22, 2024

Conversation

majora2007
Copy link
Member

@majora2007 majora2007 commented May 17, 2024 •
edited

Added

  • Added: Added a signalr event for when smart collections (MAL Stacks) are synchronizing. (develop)

Changed

  • Changed: Changed how scaling works in the manga reader to be more inline with the expected behavior. Height will scale to viewport height even if it is beyond the image's original dimensions. Width will scale to viewport width even if it is beyond the image's original dimensions. Original will show the image at its intrinsic dimensions, no scaling is applied. (Potentially Fixes "Image scale" to "width" not working as expected #2669) (Thanks @therobbiedavis)
  • Changed: Enable WAL journal mode by default in all Kavita installs. Users can turn it off after the first run if needed.
  • Changed: Show a warning on dirty email setting form to inform the user they need to save before testing settings.
  • Changed: Ensure users know that Scrobbling providers will always keep the highest number from kavita.
  • Changed: On < tablet viewports, reading list page should use order numbers rather than drag and drop, as there isn't enough real estate. (Fixes Scrolling reading list on mobile (touchscreen) reorders items #2813)
  • Changed: Fixed up some styling for the themes page (develop)

Fixed

SamuelBMartins and others added 27 commits April 27, 2024 15:39
@SamuelBMartins
Avoid multiple concurrent extractions of the same archive
0d14af0
@therobbiedavis
Fixing stacking issue with double on manga reader
1369f76 
# Fixed
- Fixed: Fixed an issue where one some screens images would stack instead of being side by side while using the double setting in the manga reader.
@therobbiedavis
Fixes cover position
3a3da4d 
Fixes #2891
@therobbiedavis
Fixed some scaling inconsistencies
4d89058
@therobbiedavis
Fixing some single reader scaling issues
1d9c0bf
@therobbiedavis
Fixing height on mobile
d4438a0
@therobbiedavis
Fixing overflow
7b0a028
@therobbiedavis
Moved to dvh instead of vh
6fa2761 
"dynamic viewport size allows the content you design to fit exactly within the viewport, irrespective of the presence of dynamic browser interfaces."
https://developer.mozilla.org/en-US/docs/Web/CSS/length#dynamic

dvh is available for all major browsers: https://caniuse.com/viewport-unit-variants
@majora2007
Merge remote-tracking branch 'refs/remotes/SamuelBMartins/bugfix/conc…
da913b2 
…urrent-extractions2' into bugfix/cleanup
@majora2007
Merge branch 'bugfix/double-reader-stacking-fix' into bugfix/cleanup
117add7
@majora2007
Fixed a bug where themes from Github weren't being cached.
54230be
@majora2007
Updated Swashbuckle to latest, which should allow showing enum descri…
dab7f75 
…ptions in generated documentation.
@majora2007
Slight styling issues on Theme manager
4b7afc7
@majora2007
Fixed up the info icon cards on series detail to be better with respo…
557f775 
…nsiveness on some breakpoints.
@majora2007
Ensure the user has a MAL token set before they use import mal stack …
ded6707 
…flow.
@majora2007
Fixed an issue where one-shot/specials in Scrobble History would show…
aee1346 
… internal encoding
@majora2007
Fixed a bug with Image series where caching the images for reading co…
e29a3c9 
…uld create a ton of folders with the same files inside.
@majora2007
Enable WAL journal mode by default in all Kavita installs. Users can …
3bfb93e 
…turn it off after the first run if needed.
@majora2007
Updated Swashbuckle tool to the latest. Added a signalr event for whe…
dcd3465 
…n smart collections (MAL Stacks) are synchronizing.
@majora2007
Show a warning on dirty email setting form to inform the user they ne…
c12ee6c 
…ed to save before testing settings.
@majora2007
Ensure users know that Scrobbling providers will always keep the high…
56f468a 
…est number from kavita.
@majora2007
On < tablet viewports, reading list page should use order numbers rat…
586eafc 
…her than drag and drop, as there isn't enough real estate.
@therobbiedavis @majora2007
fixing review card
e50ff0b
@therobbiedavis @majora2007
fixing smart filter double scrollbar
375777d
@therobbiedavis
Stylizing the theme viewer
17dce02
@therobbiedavis
Fixing a height discrepency
c05a267
@majora2007
Word count will now handle missing manifest items gracefully and repo…
fb1fd33 
…rt media errors around said file.
@majora2007 majora2007 added this to In progress in v0.8 - PDF & Comic Love via automation May 17, 2024
therobbiedavis and others added 21 commits May 20, 2024 08:04
@therobbiedavis @majora2007
Moved to dvh instead of vh
236c4f0 
"dynamic viewport size allows the content you design to fit exactly within the viewport, irrespective of the presence of dynamic browser interfaces."
https://developer.mozilla.org/en-US/docs/Web/CSS/length#dynamic

dvh is available for all major browsers: https://caniuse.com/viewport-unit-variants
@majora2007
Fixed a bug where themes from Github weren't being cached.
0d6121a
@majora2007
Updated Swashbuckle to latest, which should allow showing enum descri…
da395f9 
…ptions in generated documentation.
@majora2007
Merged robbie's theme changes
c477fc2
@majora2007
Small cleanup
f1562c0
@majora2007
Slight styling issues on Theme manager
7f1a3a1
@majora2007
Fixed up the info icon cards on series detail to be better with respo…
4fb60b9 
…nsiveness on some breakpoints.
@majora2007
Ensure the user has a MAL token set before they use import mal stack …
b703ada 
…flow.
@majora2007
Fixed an issue where one-shot/specials in Scrobble History would show…
45e4055 
… internal encoding
@majora2007
Fixed a bug with Image series where caching the images for reading co…
20b5448 
…uld create a ton of folders with the same files inside.
@majora2007
Enable WAL journal mode by default in all Kavita installs. Users can …
0d59e5e 
…turn it off after the first run if needed.
@majora2007
Updated Swashbuckle tool to the latest. Added a signalr event for whe…
330201a 
…n smart collections (MAL Stacks) are synchronizing.
@majora2007
Show a warning on dirty email setting form to inform the user they ne…
c7f4a2e 
…ed to save before testing settings.
@majora2007
Ensure users know that Scrobbling providers will always keep the high…
3b0efaf 
…est number from kavita.
@majora2007
On < tablet viewports, reading list page should use order numbers rat…
f063d5b 
…her than drag and drop, as there isn't enough real estate.
@therobbiedavis @majora2007
fixing review card
b974434
@therobbiedavis @majora2007
fixing smart filter double scrollbar
33aa545
@majora2007
Word count will now handle missing manifest items gracefully and repo…
8db13ae 
…rt media errors around said file.
@majora2007
Fixed unit tests
1cb973d
@majora2007
Updated description on default theme
04fb3b4
@majora2007
Merge remote-tracking branch 'origin/bugfix/cleanup' into bugfix/cleanup
6df75db 
# Conflicts:
#	API/Data/ManualMigrations/ManualMigrateSwitchToWal.cs
#	UI/Web/src/app/user-settings/theme-manager/theme-manager.component.html
This was referenced May 20, 2024
Closed
Closed
@majora2007 majora2007 merged commit b50fa0f into develop May 22, 2024
7 checks passed
@majora2007 majora2007 deleted the bugfix/cleanup branch May 22, 2024 11:58
v0.8 - PDF & Comic Love automation moved this from In progress to Done May 22, 2024
@majora2007 majora2007 mentioned this pull request May 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
v0.8 - PDF & Comic Love
  
Done
Milestone
No milestone
3 participants
@majora2007 @SamuelBMartins @therobbiedavis