Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link in Command buffers usage readme broken #1018

Open
wasimabbas-arm opened this issue Apr 11, 2024 · 1 comment
Open

Link in Command buffers usage readme broken #1018

wasimabbas-arm opened this issue Apr 11, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@wasimabbas-arm
Copy link
Collaborator

In the further reading section of https://github.com/KhronosGroup/Vulkan-Samples/blob/main/samples/performance/command_buffer_usage/README.adoc

Screenshot 2024-04-11 at 09 37 30

The Multi-threaded recording with multiple render passes is using this xref markdown autolink,

* xref:samples/performance/multithreading_render_passes/README.adoc[Multi-threaded recording with multiple render passes]

which is pointing at https://github.com/KhronosGroup/Vulkan-Samples/blob/main/samples/performance/command_buffer_usage/samples/performance/multithreading_render_passes/README.adoc and that doesn't exist, you get a 404.

@SaschaWillems
Copy link
Collaborator

That's an unfortunate side-effect of getting thinks properly working with docs.vulkan.org. If you click the link on that site: https://docs.vulkan.org/samples/latest/samples/performance/command_buffer_usage/README.html#_further_reading it'll work properly.

Getting documentation to work both with github and antora isn't always easy but I'll try to take a look at it.

@SaschaWillems SaschaWillems added the documentation Improvements or additions to documentation label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants