Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing error handling for unsupported samples on Android #1050

Open
SaschaWillems opened this issue May 19, 2024 · 0 comments · May be fixed by #1051
Open

Missing error handling for unsupported samples on Android #1050

SaschaWillems opened this issue May 19, 2024 · 0 comments · May be fixed by #1051
Assignees
@SaschaWillems
Labels
bug Something isn't working

Comments

@SaschaWillems
Copy link
Collaborator

SaschaWillems commented May 19, 2024 •
edited

Afair we had proper error handling for samples with e.t. unsupported extensions on Android. Running such a sample would show an error message and gracefully returned to the samples list. With a current build, this is no longer the case. Instead unsupported samples just sit there with a blank screen.

Update: It looks like we miss a permission required with Android 13 and newer. The samples do have code to request permissions, but that's unused and non-working :(
@SaschaWillems SaschaWillems added the bug Something isn't working label May 19, 2024
@SaschaWillems SaschaWillems self-assigned this May 19, 2024
SaschaWillems added a commit to SaschaWillems/Vulkan-Samples that referenced this issue May 19, 2024
@SaschaWillems
Rework error handling and display on Android
323f391 
Use a proper alert dialog displaying the last error message instead of a toast that just links to the log file
This method also does not require on any permissions (unlike toasts)
Fixes KhronosGroup#1050
@SaschaWillems SaschaWillems linked a pull request May 19, 2024 that will close this issue
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SaschaWillems SaschaWillems

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix and rework Android error notifications SaschaWillems/Vulkan-Samples
1 participant
@SaschaWillems