Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreating resources in Arm sample framework fundamentally broken (Subpass samples, etc.) #920

Open
SaschaWillems opened this issue Feb 19, 2024 · 1 comment
Assignees
Labels
bug Something isn't working framework This is relevant to the framework sample This is relevant to a sample

Comments

@SaschaWillems
Copy link
Collaborator

SaschaWillems commented Feb 19, 2024

While trying to fix the sync issues in the subpass sample (#455, #867) I noticed that it seems to be fundamentally broken/flawed. When enabling sync validation, the sample crashes the validation layers. After a few hours of debugging, it looks like it's trying to update the swap chain without properly making sure resources in use are waited on, resulting in validation crash. This happens right at startup. I was able to fix that one, but a similar error happens on resize. I'm looking into this, but may need some assistance as this is a sample done by Arm using the Arm sample framework, so lots of indirections and implicit things happening that are very hard to debug.

image

@SaschaWillems SaschaWillems added bug Something isn't working sample This is relevant to a sample labels Feb 19, 2024
@SaschaWillems
Copy link
Collaborator Author

This seems to affect several samples based on the Arm framework. I can reproduce this, albeit not with every single start/resize with e.g. the MSAA and also the command buffer usage sample. I think this is caused by how the framework recreates framebuffers/swapchains and as such may be a fundamental flaw in the Arm framework.

@SaschaWillems SaschaWillems changed the title Subpass sample fundamentally broken Recreating resources in Arm sample framework fundamentally broken (Subpass samples, etc.) Feb 19, 2024
@SaschaWillems SaschaWillems self-assigned this Feb 19, 2024
@SaschaWillems SaschaWillems added the framework This is relevant to the framework label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working framework This is relevant to the framework sample This is relevant to a sample
Projects
None yet
Development

No branches or pull requests

1 participant