New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precommit formatting is applied to non-source files #997

Open

SaschaWillems opened this issue Mar 23, 2024 · 0 comments

Labels

build

Collaborator

SaschaWillems commented Mar 23, 2024 •

edited

I just wanted to push a very minor documentation fix, but with precommit from #939 enabled all I got when trying to push was this cryptic error:

I noticed that I had a new commit in my changes that removed some trailing spaces, something I didn't touch on and didn't want to change.

What's problematic about this is that git didn't let me push my actual change without also pushing the precommit fix.

To get around this I had to uninstall precommit.

Maybe we should exclude non-source files from precommit (if that's actually possible)?

SaschaWillems added the build label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment