Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thresholds updated in package.json when --configPath is provided #8

Open
provthomas opened this issue Jan 23, 2019 · 2 comments
Open

Comments

@provthomas
Copy link

No description provided.

@ayansome1
Copy link

I am facing the same issue

@JonathanATaylor
Copy link

Yep, I'm experiencing this as well. Judging by line 33 of src/program.js, the --configPath is only used to read the original thresholds. When writing the new thresholds, the app goes straight for the package.json:
R.chain(thresholds => F.both(getPackageJsonPath(), F.of(thresholds))),
Surely this not the desired behavior, as it results in having coverage thresholds set in two different files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants