Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounding coverage values down #9

Open
Firellon opened this issue Apr 16, 2019 · 3 comments
Open

Rounding coverage values down #9

Firellon opened this issue Apr 16, 2019 · 3 comments

Comments

@Firellon
Copy link

How do you guys handle small (<1%) fluctuations of coverage values?
I propose to enable an option to round the threshold values down in order to avoid errors thrown on minor test coverage decrements

utils.js

const takeMaxValues = R.reduce(
  (result, [key, val]) =>
    R.merge(result, { [key]: R.max(result[key] || 0, Math.floor(val)) }),
  {}
)
@benadamstyles
Copy link

I've patched my own local version of this package to include this functionality, I'd like to make a PR to upstream it into this package but I just want to be sure before I do that you will be up for merging it, @Koleok?

@Koleok
Copy link
Owner

Koleok commented Jun 15, 2020

@benadamstyles Sure thing 👍

@etylsarin
Copy link

Hi @Koleok as @benadamstyles hasn't done the PR, would you mind to incorporate the change @Firellon proposed?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants