fix(proxy-cache): changes age param #12812
Conversation
|
|
github-actions
bot
added
plugins/proxy-cache
schema-change-noteworthy
cherry-pick kong-ee
team-eng-enablement
added
the
author/community
joelact
force-pushed
the
master
branch
4 times, most recently
from
1a869ca
to
b77c205
Compare
|
Thanks for your contribution @joelact. Your change includes a schema change, which requires additional steps to ensure backwards compatibility with older Kong versions. If you choose to follow-up on those, I'm happy to assist you in doing so. |
|
Hey @jschmid1. Thanks for taking a look at this. |
|
Sure @joelact, Your change qualifies as a "rename" of a field. To ensure compatibility to older versions when running Kong in hybrid-mode you have to teach the Kong how to manipulate the plugin config so that older versions still understand it. You can take a look at the compatibility checkers here -> https://github.com/Kong/kong/blob/master/kong/clustering/compat/checkers.lua and for testing check this file -> https://github.com/Kong/kong/blob/master/spec/02-integration/09-hybrid_mode/09-config-compat_spec.lua |
joelact
force-pushed
the
master
branch
2 times, most recently
from
024563e
to
19133ea
Compare
joelact
force-pushed
the
master
branch
2 times, most recently
from
952e55d
to
a95dedb
Compare
The age parameter on the schema was in lower case which caused the header Age to appear only when the kong debug option was enabled. This commit changes the schema parameter from age to Age. Fix Kong#12787
|
Hey @jschmid1! Sorry for the delay in completing the mentioned actions. When possible can you review this again? |
Summary
The age parameter on the schema was in lower case which caused the header Age to appear only when the kong debug option was enabled. This commit changes the schema parameter from age to Age.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #12787