Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local_user.auto_expand images in favor of local_user.post_listing_mode #4643

Open
5 tasks done
dessalines opened this issue Apr 19, 2024 · 2 comments
Open
5 tasks done

Comments

@dessalines
Copy link
Member

Requirements

  • Is this a feature request? For questions or discussions use https://lemmy.ml/c/lemmy_support
  • Did you check to see if this issue already exists?
  • Is this only a feature request? Do not put multiple feature requests in one issue.
  • Is this a backend issue? Use the lemmy-ui repo for UI / frontend issues.
  • Do you agree to follow the rules in our Code of Conduct?

Is your proposal related to a problem?

Auto-expanding images isn't a setting that would work well with every type of post_listing_mode, which are currently : Card, SmallCard, and List .

Also, auto-expand images doesn't exist at the local_site level, only the local_user level, whereas post_listing_mode exists at both levels, so is more versatile. A site can set a default post_listing_mode, and that can also be overridden by a local user setting.

Describe the solution you'd like.

Get rid of the local_user.auto_expand setting.

Describe alternatives you've considered.

NA

Additional context

cc @SleeplessOne1917 @MV-GH @matc-pub

@MV-GH
Copy link
Contributor

MV-GH commented Apr 19, 2024

Didn't know that existed, don't think we use it in Jerboa

@dessalines
Copy link
Member Author

Ya it was recently added, we'll need to add it at some point.

@Nutomic Nutomic added this to the 0.20.0 milestone May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants