Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Image proxying broken #4703

Closed
5 tasks done
dessalines opened this issue May 5, 2024 · 0 comments · May be fixed by #4704
Closed
5 tasks done

[Bug]: Image proxying broken #4703

dessalines opened this issue May 5, 2024 · 0 comments · May be fixed by #4704
Assignees
@dessalines
Labels
bug Something isn't working
Milestone
0.19.4

Comments

@dessalines
Copy link
Member

Requirements

  • Is this a bug report? For questions or discussions use https://lemmy.ml/c/lemmy_support
  • Did you check to see if this issue already exists?
  • Is this only a single bug? Do not put multiple bugs in one issue.
  • Do you agree to follow the rules in our Code of Conduct?
  • Is this a backend issue? Use the lemmy-ui repo for UI / frontend issues.

Summary

I'm having to rework the image-proxying logic again, because on actual testing with Pictrs:ProxyAllImages, its overwriting not just the thumbnails, but also the post urls.

Steps to Reproduce

  1. Create a non-image post, with the above pictrs proxy setting on.
  2. The url itself gets overwritten into a proxied one, even though its not an image.
  3. The thumbnail_url proxies itself twice.

Technical Details

See above

Version

main

Lemmy Instance URL

main
@dessalines dessalines added the bug Something isn't working label May 5, 2024
@dessalines dessalines self-assigned this May 5, 2024
dessalines added a commit that referenced this issue May 6, 2024
@dessalines
Adding an image_details table to store image dimensions.
ee7df0d 
- Adds an image_details table, which stores the height,
  width, and content_type for local and remote images.
- For LocalImages, this information already comes back with
  the upload.
- For RemoteImages, it calls the pictrs details endpoint.
- Fixed some issues with proxying non-image urls.
- Fixes #3328
- Also fixes #4703
@dessalines dessalines mentioned this issue May 6, 2024
Draft
@dessalines dessalines added this to the 0.19.4 milestone May 7, 2024
dessalines added a commit that referenced this issue May 15, 2024
@dessalines
Fixing proxy image fetching. Fixes #4703
5f1515f 
- This extracts only the proxy image fixes from #4704, leaving off
  thumbnails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dessalines dessalines

Labels
bug Something isn't working
Projects
None yet
Milestone
0.19.4
Development

Successfully merging a pull request may close this issue.

Adding an image_details table to store image dimensions. LemmyNet/lemmy
1 participant
@dessalines