{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":778365733,"defaultBranch":"unstable","name":"placeholderkv","ownerLogin":"LiiNen","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2024-03-27T15:31:48.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/38001238?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1716952608.0","currentOid":""},"activityList":{"items":[{"before":"153625c02ea7132e6476e622c78ceb605e0a36f6","after":"a294f662d29823ff19669d3f763033d8339ca460","ref":"refs/heads/bitcount-end-as-optional","pushedAt":"2024-05-29T03:25:22.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Merge branch 'valkey-io:unstable' into bitcount-end-as-optional","shortMessageHtmlLink":"Merge branch 'valkey-io:unstable' into bitcount-end-as-optional"}},{"before":"9499b06a4d75438bc2aa5a39bec8dfd07ee35de7","after":"153625c02ea7132e6476e622c78ceb605e0a36f6","ref":"refs/heads/bitcount-end-as-optional","pushedAt":"2024-05-29T03:24:43.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Merge branch 'unstable' into bitcount-end-as-optional\n\nSigned-off-by: LiiNen ","shortMessageHtmlLink":"Merge branch 'unstable' into bitcount-end-as-optional"}},{"before":null,"after":"178a8217ba91b49e1cf568aff2689f3a4472d52b","ref":"refs/heads/fix-bitops-clang-format","pushedAt":"2024-05-29T03:16:48.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Fix bitops.c clang-format properly\n\nSigned-off-by: LiiNen ","shortMessageHtmlLink":"Fix bitops.c clang-format properly"}},{"before":"153625c02ea7132e6476e622c78ceb605e0a36f6","after":"9499b06a4d75438bc2aa5a39bec8dfd07ee35de7","ref":"refs/heads/bitcount-end-as-optional","pushedAt":"2024-05-29T03:13:31.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Merge branch 'valkey-io:unstable' into bitcount-end-as-optional","shortMessageHtmlLink":"Merge branch 'valkey-io:unstable' into bitcount-end-as-optional"}},{"before":"553a75c5afa6469594829f1790431da441f37647","after":"153625c02ea7132e6476e622c78ceb605e0a36f6","ref":"refs/heads/bitcount-end-as-optional","pushedAt":"2024-05-29T03:12:40.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Merge branch 'unstable' into bitcount-end-as-optional\n\nSigned-off-by: LiiNen ","shortMessageHtmlLink":"Merge branch 'unstable' into bitcount-end-as-optional"}},{"before":"153625c02ea7132e6476e622c78ceb605e0a36f6","after":"553a75c5afa6469594829f1790431da441f37647","ref":"refs/heads/bitcount-end-as-optional","pushedAt":"2024-05-29T03:09:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Fix clang-format properly\n\njust running clang-format -i bitops.c\n\nSigned-off-by: LiiNen ","shortMessageHtmlLink":"Fix clang-format properly"}},{"before":"e4ead9442b8e970defc26d25c62580bedfd42a80","after":"96dcd1183afa803d30ec71c574e80e3dc01c1f6e","ref":"refs/heads/unstable","pushedAt":"2024-05-29T03:05:42.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Change BITCOUNT 'end' as optional like BITPOS (#118)\n\n_This change is the thing I suggested to redis when it was BSD, and is\r\nnot just migration - this is of course more advanced_\r\n\r\n### Issue\r\nThere is weird difference in syntax between BITPOS and BITCOUNT:\r\n```\r\nBITPOS key bit [start [end [BYTE | BIT]]]\r\nBITCOUNT key [start end [BYTE | BIT]]\r\n```\r\n\r\nI think this might cause confusion in terms of usability.\r\nIt was not just a syntax typo error, and really works differently.\r\nThe results below are with unstable build:\r\n```\r\n> get TEST:ABCD\r\n\"ABCD\"\r\n> BITPOS TEST:ABCD 1 0 -1\r\n(integer) 1\r\n> BITCOUNT TEST:ABCD 0 -1\r\n(integer) 9\r\n> BITPOS TEST:ABCD 1 0\r\n(integer) 1\r\n> BITCOUNT TEST:ABCD 0\r\n(error) ERR syntax error\r\n```\r\n\r\n### What did I fix\r\n\r\nsimply changes logic, to accept BITCOUNT also without 'end' - 'end'\r\nbecome optional, like BITPOS\r\n```\r\n> GET TEST:ABCD\r\n\"ABCD\"\r\n> BITPOS TEST:ABCD 1 0 -1\r\n(integer) 1\r\n> BITCOUNT TEST:ABCD 0 -1\r\n(integer) 9\r\n> BITPOS TEST:ABCD 1 0\r\n(integer) 1\r\n> BITCOUNT TEST:ABCD 0\r\n(integer) 9\r\n```\r\n\r\nOf course, I also fixed syntax hint:\r\n```\r\n# ASIS \r\n> BITCOUNT key [start end [BYTE|BIT]]\r\n# TOBE\r\n> BITCOUNT key [start [end [BYTE|BIT]]]\r\n```\r\n\r\n![image](https://github.com/valkey-io/valkey/assets/38001238/8485f58e-6785-4106-9f3f-45e62f90d24b)\r\n\r\n\r\n### Moreover ...\r\nI hadn't noticed that there was very small dead code in these command\r\nlogic, when I wrote PR to redis.\r\nI found it now, when write code again, so I wrote it in valkey.\r\n``` c\r\n/* asis unstable */\r\n\r\n/* bitcountCommand() */\r\nif (!strcasecmp(c->argv[4]->ptr,\"bit\")) isbit = 1;\r\n// ...\r\nif (c->argc < 4) {\r\n if (isbit) end = (totlen<<3) + 7;\r\n else end = totlen-1;\r\n}\r\n\r\n/* bitposCommand() */\r\nif (!strcasecmp(c->argv[5]->ptr,\"bit\")) isbit = 1;\r\n// ...\r\nif (c->argc < 5) {\r\n if (isbit) end = (totlen<<3) + 7;\r\n else end = totlen-1;\r\n}\r\n```\r\nBit variable (actually int) \"isbit\" is only being set as 1, when 'BIT'\r\nis declared.\r\nBut we were checking whether 'isbit' is true or false in this 'if'\r\nphrase, even if isbit could never be 1, because argc is always less than\r\n4 (or 5 in bitpos).\r\n\r\n\r\n\r\nI think this minor fixes will make valkey command operation more\r\nconsistent.\r\nOf course, this PR contains just changing args from \"required\" to\r\n\"optional\", so it will never hurt previous users.\r\n\r\nThanks,\r\n\r\n---------\r\n\r\nSigned-off-by: LiiNen \r\nCo-authored-by: Madelyn Olson <34459052+madolson@users.noreply.github.com>","shortMessageHtmlLink":"Change BITCOUNT 'end' as optional like BITPOS (valkey-io#118)"}},{"before":"843c84a09142dad2ecf938e292053828befbe39e","after":"153625c02ea7132e6476e622c78ceb605e0a36f6","ref":"refs/heads/bitcount-end-as-optional","pushedAt":"2024-05-27T15:03:25.000Z","pushType":"push","commitsCount":195,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Merge branch 'unstable' into bitcount-end-as-optional\n\nSigned-off-by: LiiNen ","shortMessageHtmlLink":"Merge branch 'unstable' into bitcount-end-as-optional"}},{"before":"6411629c617e3e8800fb083938bd9883a3a9db33","after":"e4ead9442b8e970defc26d25c62580bedfd42a80","ref":"refs/heads/unstable","pushedAt":"2024-05-27T14:33:27.000Z","pushType":"push","commitsCount":139,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Make CLUSTER SETSLOT with TIMEOUT 0 block indefinitely (#556)\n\nThis aligns the behaviour with established Valkey commands with a\r\nTIMEOUT argument, such as BLPOP.\r\n\r\nFix #422\r\n\r\nSigned-off-by: Ping Xie ","shortMessageHtmlLink":"Make CLUSTER SETSLOT with TIMEOUT 0 block indefinitely (valkey-io#556)"}},{"before":"c0dd4eea15e20420e0b4c52b7cb770a0f6e73861","after":"843c84a09142dad2ecf938e292053828befbe39e","ref":"refs/heads/bitcount-end-as-optional","pushedAt":"2024-04-29T14:42:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Add test cases; larger value, negative larger value\n\nSigned-off-by: LiiNen ","shortMessageHtmlLink":"Add test cases; larger value, negative larger value"}},{"before":"ef859a1c6d8a39a23b26eade4a1987d9487787ce","after":"f1988f82a90d2737d2fbabb8e7eaad85f9794208","ref":"refs/heads/access-log","pushedAt":"2024-04-08T11:35:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Fix condition: only for loglevel is verbose\n\nSigned-off-by: LiiNen ","shortMessageHtmlLink":"Fix condition: only for loglevel is verbose"}},{"before":"9b25e35a804edc08f5c39fc539e818aaa3239cb7","after":"ef859a1c6d8a39a23b26eade4a1987d9487787ce","ref":"refs/heads/access-log","pushedAt":"2024-04-08T10:59:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Fix typo\n\nSigned-off-by: LiiNen ","shortMessageHtmlLink":"Fix typo"}},{"before":"257c8f4198d0bb1a8b0cf0bd16e7b14a71d23513","after":"9b25e35a804edc08f5c39fc539e818aaa3239cb7","ref":"refs/heads/access-log","pushedAt":"2024-04-08T10:58:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Add verbosity edit logic if it is defined\n\nSigned-off-by: LiiNen ","shortMessageHtmlLink":"Add verbosity edit logic if it is defined"}},{"before":"4e82f71a3c4299e49eb05c9d6fde4f22a62934cc","after":"257c8f4198d0bb1a8b0cf0bd16e7b14a71d23513","ref":"refs/heads/access-log","pushedAt":"2024-04-08T10:51:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Add fp check in config, with fix condition for only verbose\n\nSigned-off-by: LiiNen ","shortMessageHtmlLink":"Add fp check in config, with fix condition for only verbose"}},{"before":null,"after":"4e82f71a3c4299e49eb05c9d6fde4f22a62934cc","ref":"refs/heads/access-log","pushedAt":"2024-04-08T10:29:59.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Add audit logfile in config\n\nSigned-off-by: LiiNen ","shortMessageHtmlLink":"Add audit logfile in config"}},{"before":"621edbafba74c2d6211bf81d54be8b1da8543d4e","after":"6411629c617e3e8800fb083938bd9883a3a9db33","ref":"refs/heads/unstable","pushedAt":"2024-04-08T08:48:26.000Z","pushType":"push","commitsCount":51,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Madelyn's attempt as a logo (#251)\n\nApply new logo at startup.\r\n\r\nIt is one character wider and 2 characters taller than the original\r\nRedis logo.\r\n\r\n---------\r\n\r\nSigned-off-by: Madelyn Olson ","shortMessageHtmlLink":"Madelyn's attempt as a logo (valkey-io#251)"}},{"before":"729ec8b39f54f2c51f0dccb09c9da788b476cc65","after":"c0dd4eea15e20420e0b4c52b7cb770a0f6e73861","ref":"refs/heads/bitcount-end-as-optional","pushedAt":"2024-04-02T17:00:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Fix test code : allowing bitcount without end now\n\nSigned-off-by: LiiNen ","shortMessageHtmlLink":"Fix test code : allowing bitcount without end now"}},{"before":"83507d74b8588d2d8561a263466d34ee669d9812","after":"621edbafba74c2d6211bf81d54be8b1da8543d4e","ref":"refs/heads/unstable","pushedAt":"2024-04-02T16:56:19.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Rename redisassert to serverassert in comment (#142)\n\nSigned-off-by: 0del ","shortMessageHtmlLink":"Rename redisassert to serverassert in comment (valkey-io#142)"}},{"before":null,"after":"c3963e836829155636f759680ea528d25379b024","ref":"refs/heads/rename-conf","pushedAt":"2024-04-02T15:14:25.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Rename conf redis.conf to valkey.conf\n\nSigned-off-by: LiiNen ","shortMessageHtmlLink":"Rename conf redis.conf to valkey.conf"}},{"before":"e6b40406430530f6becfbe16a8f732666decb802","after":"86dce25a52de9c8c53e3266289907eb43b635f56","ref":"refs/heads/fix-shutdown-hint","pushedAt":"2024-04-02T13:00:28.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Add files after built, with command comment in db.c\n\nSigned-off-by: LiiNen ","shortMessageHtmlLink":"Add files after built, with command comment in db.c"}},{"before":"fd83b40b165e7f99804bc23448a2296796243630","after":"729ec8b39f54f2c51f0dccb09c9da788b476cc65","ref":"refs/heads/bitcount-end-as-optional","pushedAt":"2024-04-02T12:59:35.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Update tests/unit/bitops.tcl\n\nCo-authored-by: Madelyn Olson <34459052+madolson@users.noreply.github.com>\nSigned-off-by: LiiNen ","shortMessageHtmlLink":"Update tests/unit/bitops.tcl"}},{"before":"bdd7314f419e07e5ad0b21b0d3e801aef280f902","after":"83507d74b8588d2d8561a263466d34ee669d9812","ref":"refs/heads/unstable","pushedAt":"2024-04-02T12:57:01.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Update for latest 'typos' (#139)\n\nSigned-off-by: john vandenberg \r\nCo-authored-by: john vandenberg ","shortMessageHtmlLink":"Update for latest 'typos' (valkey-io#139)"}},{"before":"3fbebc4921876628fe35bd92101fb9eb99937d69","after":"fd83b40b165e7f99804bc23448a2296796243630","ref":"refs/heads/bitcount-end-as-optional","pushedAt":"2024-04-02T03:08:31.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Update tests/unit/bitops.tcl\n\nCo-authored-by: Madelyn Olson <34459052+madolson@users.noreply.github.com>\nSigned-off-by: LiiNen ","shortMessageHtmlLink":"Update tests/unit/bitops.tcl"}},{"before":"54c99f5bf38e830a2c7cefcce7397058e79c4e55","after":"3fbebc4921876628fe35bd92101fb9eb99937d69","ref":"refs/heads/bitcount-end-as-optional","pushedAt":"2024-04-02T03:06:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Update tests/unit/bitops.tcl\n\nCo-authored-by: Madelyn Olson <34459052+madolson@users.noreply.github.com>","shortMessageHtmlLink":"Update tests/unit/bitops.tcl"}},{"before":"bcd3a77df5d20f9f563343613bfab74949a895f0","after":"54c99f5bf38e830a2c7cefcce7397058e79c4e55","ref":"refs/heads/bitcount-end-as-optional","pushedAt":"2024-04-02T03:06:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Add commands.def after build\n\nSigned-off-by: LiiNen ","shortMessageHtmlLink":"Add commands.def after build"}},{"before":"ecbcc8b233d117b8d1d55359a5d62d4ffce202b1","after":"bcd3a77df5d20f9f563343613bfab74949a895f0","ref":"refs/heads/bitcount-end-as-optional","pushedAt":"2024-04-02T03:00:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Add history for this fix\n\nSigned-off-by: LiiNen ","shortMessageHtmlLink":"Add history for this fix"}},{"before":"338c5d1a0f103fbc7ade25ef4d801cb30a52b486","after":"ecbcc8b233d117b8d1d55359a5d62d4ffce202b1","ref":"refs/heads/bitcount-end-as-optional","pushedAt":"2024-04-01T15:25:06.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Add commands.def after build\n\nSigned-off-by: LiiNen ","shortMessageHtmlLink":"Add commands.def after build"}},{"before":"208a2f67efec244af2de53c1870ab74fee3b0581","after":"338c5d1a0f103fbc7ade25ef4d801cb30a52b486","ref":"refs/heads/bitcount-end-as-optional","pushedAt":"2024-04-01T15:06:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Add commands.def after build","shortMessageHtmlLink":"Add commands.def after build"}},{"before":"cbd6e512af460961273208771c2151d149f33b1a","after":"208a2f67efec244af2de53c1870ab74fee3b0581","ref":"refs/heads/bitcount-end-as-optional","pushedAt":"2024-04-01T14:56:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Move line end = totlen - 1, after totlen declared","shortMessageHtmlLink":"Move line end = totlen - 1, after totlen declared"}},{"before":null,"after":"cbd6e512af460961273208771c2151d149f33b1a","ref":"refs/heads/bitcount-end-as-optional","pushedAt":"2024-04-01T14:52:37.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"LiiNen","name":"LiiNen","path":"/LiiNen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38001238?s=80&v=4"},"commit":{"message":"Remove unreachable code in BITCOUNT and BITPOS\n\nin case of end is not declared, BYTE|BIT cannot be used, so variable 'isbit' is always 0","shortMessageHtmlLink":"Remove unreachable code in BITCOUNT and BITPOS"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEVntVaQA","startCursor":null,"endCursor":null}},"title":"Activity ยท LiiNen/placeholderkv"}