Skip to content
This repository has been archived by the owner on Feb 17, 2021. It is now read-only.

Updating coding style #138

Open
dgattey opened this issue Apr 27, 2017 · 1 comment
Open

Updating coding style #138

dgattey opened this issue Apr 27, 2017 · 1 comment

Comments

@dgattey
Copy link
Contributor

dgattey commented Apr 27, 2017

Per LinkedIn and Apple's latest style guides, LayoutKit does not conform to either. viewReuseId -> viewReuseID for example, and all k prefixed constants shouldn't be k prefixed. There's a lot more here too. We need a pass through to update the style everywhere.

See LinkedIn's styleguide and Apple's API design guidelines

Additionally, layouts have parameters in different orders and by different names (config vs. configuration for example). It will be a breaking change, but we should make it at some point to standardize layout initializers and clarify our code.

@nicksnyder
Copy link
Collaborator

I would bundle this type of change with some other breaking change that we want to make instead of doing a breaking release just to rename stuff.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants