Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW FEATURE] Luos updates to be launched by Pyluos and not by Gate #405

Open
BiliouriV opened this issue Nov 18, 2022 · 0 comments
Open
Assignees
Labels
advanced Advanced skills are needed for this subject

Comments

@BiliouriV
Copy link
Contributor

Before to begin

Thank you for contributing to the Luos project!

Before to begin, please ensure that the feature you are requesting doesn't exist yet (you can use the GitHub searchbar with keywords to look for other issues).

If you only have a usage question, ask it to the Luos Community.

At last, feel free to read the Luos contribution's guidelines and the documentation page to have more insight about how to contribute to Luos!

Details

Please replace the italic test by your inputs and details in each of the following sections:

What feature would you like to be included in Luos?

Updates should be initiated by a Pyluos Command and not by default in gate after the end of a detection

Describe the expected behavior of the feature

In Pyluos each time we finish a detection by default we should launch the updates in order to get the values we need of each node. Right now its the gate that does this automatically. In other cases as for example the detection launched before starting the bootloader we should not ask for updates because we should not provoke the collision of necessary messages that may harm the procedure.

What is the motivation / use case for changing the behavior?

The first bootloader message that puts the boards in APP_RELOAD_MODE does not always arrives to every node because of unecessary updates that should not exist in that case. Anyways the gate should not ask by default for the updates. The updates when we use gate to get them are only used in high level (for example when we use pyluos) so it is on high level that we should ask the nodes to start sending them.

Thank you! Your issue will be reviewed by our admins.

@BiliouriV BiliouriV added the advanced Advanced skills are needed for this subject label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
advanced Advanced skills are needed for this subject
Projects
None yet
Development

No branches or pull requests

2 participants