Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signatures redesign - Separate lines within personal sign message #24480

Closed
9 tasks
bschorchit opened this issue May 10, 2024 · 0 comments · Fixed by #24500
Closed
9 tasks

Signatures redesign - Separate lines within personal sign message #24480

bschorchit opened this issue May 10, 2024 · 0 comments · Fixed by #24500
Assignees
@jpuri
Labels
release-11.18.0 Issue or pull request that will be included in release 11.18.0 team-confirmations Push issues to confirmations team

Comments

@bschorchit
Copy link

bschorchit commented May 10, 2024 •
edited

What is this about?

We should keep the old confirmation behavior of separating lines within personal sign message for improved readability. See screenshots below.

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

Screenshot 2024-05-10 at 10 37 45 Screenshot 2024-05-10 at 10 41 45
@bschorchit bschorchit added the team-confirmations Push issues to confirmations team label May 10, 2024
@jpuri jpuri self-assigned this May 12, 2024
@jpuri jpuri mentioned this issue May 13, 2024
Merged
7 tasks
@metamaskbot metamaskbot added the release-11.18.0 Issue or pull request that will be included in release 11.18.0 label May 16, 2024
@jpuri jpuri mentioned this issue May 16, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpuri jpuri

Labels
release-11.18.0 Issue or pull request that will be included in release 11.18.0 team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: newline display in signature request content. MetaMask/metamask-extension
3 participants
@jpuri @bschorchit @metamaskbot