-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: newline display in signature request content. #24500
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [8726a37]
Page Load Metrics (747 ± 566 ms)
Bundle size diffs
|
Hey @jpuri the original issue has been solved but the text isn't wrapping around and is bleeding out of the window. See screenshot below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24500 +/- ##
========================================
Coverage 67.48% 67.48%
========================================
Files 1288 1288
Lines 50153 50153
Branches 13023 13023
========================================
Hits 33842 33842
Misses 16311 16311 ☔ View full report in Codecov by Sentry. |
Builds ready [24c49c2]
Page Load Metrics (918 ± 627 ms)
Bundle size diffs
|
Description
Newline is not preserved in re-designed signature pages.
Related issues
Fixes: #24480
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist