You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, we add the ui_customizations "redesigned_confirmation" event property for redesigned signatures. This happens in createRPCMethodTrackingMiddleware.js. We will need to add the same property for redesigned transactions.
A challenge with doing this in createRPCMethodTrackingMiddleware.js is that the method we check is the eth method. For the contract interaction transaction type, the method would equal eth_call. We can consider using updateTransactionEventFragment for the solution.
Repro:
set ENABLE_CONFIRMATION_REDESIGN=true in .metamaskrc
enable Experimental > Redesign Confirmation in settings
enable Participate in MetaMetrics in settings
test redesigned transactions (Contract Interaction) e.g. test-dapp Mint NFT
observe "Transaction <Rejected|Canceled|Approved>" event with new ui_customizations
Scenario
No response
Design
No response
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
No response
Stakeholder review needed before the work gets merged
Engineering (needed in most cases)
Design
Product
QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
Security
Legal
Marketing
Management (please specify)
Other (please specify)
References
No response
The text was updated successfully, but these errors were encountered:
What is this about?
Currently, we add the
ui_customizations
"redesigned_confirmation" event property for redesigned signatures. This happens increateRPCMethodTrackingMiddleware.js
. We will need to add the same property for redesigned transactions.A challenge with doing this in
createRPCMethodTrackingMiddleware.js
is that the method we check is the eth method. For the contract interaction transaction type, the method would equaleth_call
. We can consider using updateTransactionEventFragment for the solution.Repro:
ENABLE_CONFIRMATION_REDESIGN=true
in .metamaskrcui_customizations
Scenario
No response
Design
No response
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
No response
Stakeholder review needed before the work gets merged
References
No response
The text was updated successfully, but these errors were encountered: