Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Delegation transaction gets stuck until tx is confirmed #24493

Open
hesterbruikman opened this issue May 11, 2024 · 0 comments
Open

[Bug]: Delegation transaction gets stuck until tx is confirmed #24493

hesterbruikman opened this issue May 11, 2024 · 0 comments
Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. Sev2-normal Normal severity; minor loss of service or inconvenience. team-transactions Transactions team type-bug

Comments

@hesterbruikman
Copy link

hesterbruikman commented May 11, 2024

Describe the bug

This issue affects every dApp interacting with Metamask and is visible on dapp. When Metamask submits the transaction to the blockchain and dapp is waiting for confirmation. Dapp does not display the correct "processing" modal.

Occurs with Bulk Execute on Safe and Delegation transaction.

Expected behavior

See ethers-io/ethers.js#4722

await on contract.function resolves after the transaction has been submitted

Current behavior

await on contract.function resolves after the transaction has been confirmed

Steps to reproduce

  • Go to dapp (e.g. Safe, see issue report)
  • Sign transaction
  • Dapp shows does not update UI requesting user to sign confirmation (e.g. "Go to your wallet" UI) until tx is confirmed

Error messages or log output

No response

Version

11.14.5

Build type

None

Browser

Other (please elaborate in the "Additional Context" section)

Operating system

Other (please elaborate in the "Additional Context" section)

Hardware wallet

No response

Additional context

No response

Severity

Might be visible as a drop in transactions if users drop of after approval seems stuck.

@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label May 11, 2024
@gauthierpetetin gauthierpetetin added Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team labels May 13, 2024
@bschorchit bschorchit added team-transactions Transactions team and removed team-confirmations Push issues to confirmations team labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. Sev2-normal Normal severity; minor loss of service or inconvenience. team-transactions Transactions team type-bug
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

4 participants