Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal Bug]: Send - Sending a tx breaks the wallet with error ConfirmationInfoComponentMap [(intermediate value) is not a function #24510

Closed
seaona opened this issue May 14, 2024 · 2 comments · Fixed by #24519
Assignees
Labels
regression-RC-11.17.0 release-11.17.0 Issue or pull request that will be included in release 11.17.0 release-11.18.0 Issue or pull request that will be included in release 11.18.0 release-blocker This bug is blocking the next release Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-confirmations Push issues to confirmations team type-bug

Comments

@seaona
Copy link
Contributor

seaona commented May 14, 2024

Describe the bug

With the feature flag ENABLE_CONFIRMATION_REDESIGN , whenever I start sending a tx, I see MM breaks with errors:

  • Message: ConfirmationInfoComponentMap[(intermediate value)] is not a function
    Once this happens, even if I re-start the wallet, I see the error. The only way to recover from this state is restart the wallet and change networks before login in.

Expected behavior

No response

Screenshots/Recordings

Screenshot from 2024-05-14 09-19-53

image

intermediate-valu-not-func.mp4

Steps to reproduce

  1. Build the wallet yarn dist or yarn start with the feature flag on ENABLE_CONFIRMATION_REDESIGN
  2. Start a tx
  3. After adding a recipient and amount, proceed to the next screen
  4. See how MM breaks

Error messages or log output

No response

Version

develop: both MV3 and non- MV3 builds

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response

@seaona seaona added type-bug Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. labels May 14, 2024
@seaona seaona changed the title [Bug]: Send - Sending a tx breaks the wallet with error t[(intermediate value)(intermediate value)(intermediate value)] is not a function [Bug]: Send - Sending a tx breaks the wallet with error ConfirmationInfoComponentMap [(intermediate value)(intermediate value)(intermediate value)] is not a function May 14, 2024
@seaona seaona changed the title [Bug]: Send - Sending a tx breaks the wallet with error ConfirmationInfoComponentMap [(intermediate value)(intermediate value)(intermediate value)] is not a function [Bug]: Send - Sending a tx breaks the wallet with error ConfirmationInfoComponentMap [(intermediate value) is not a function May 14, 2024
@seaona seaona added team-confirmations Push issues to confirmations team and removed team-wallet-ux Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. labels May 14, 2024
@seaona
Copy link
Contributor Author

seaona commented May 14, 2024

I've seen this is only affecting the Confirmation Redesign builds, so I've updated the labels and sev accordingly

@jpuri jpuri self-assigned this May 14, 2024
@seaona seaona changed the title [Bug]: Send - Sending a tx breaks the wallet with error ConfirmationInfoComponentMap [(intermediate value) is not a function [Internal Bug]: Send - Sending a tx breaks the wallet with error ConfirmationInfoComponentMap [(intermediate value) is not a function May 14, 2024
@bschorchit bschorchit added release-blocker This bug is blocking the next release release-11.17.0 Issue or pull request that will be included in release 11.17.0 Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. labels May 14, 2024
@digiwand
Copy link
Contributor

since ENABLE_CONFIRMATION_REDESIGN will be turned off in production I don't think this would be a sev1 and I don't think it'd be needed for v11.17.0. Redesign Signatures no longer live behind the ENABLE_CONFIRMATION_REDESIGN flag cc: @bschorchit @seaona

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-RC-11.17.0 release-11.17.0 Issue or pull request that will be included in release 11.17.0 release-11.18.0 Issue or pull request that will be included in release 11.18.0 release-blocker This bug is blocking the next release Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-confirmations Push issues to confirmations team type-bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants