Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: confirmation page not loading if re-design is enabled #24519

Merged
merged 2 commits into from
May 16, 2024
Merged

fix: confirmation page not loading if re-design is enabled #24519

merged 2 commits into from
May 16, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented May 14, 2024

Description

fix: confirmation page not loading if re-design is enabled

Related issues

Fixes: #24510

Manual testing steps

  1. Build the wallet yarn dist or yarn start with the feature flag on ENABLE_CONFIRMATION_REDESIGN
  2. Start a tx
  3. After adding a recipient and amount, proceed to the next screen
  4. Confirmation page opens successfully

Screenshots/Recordings

Screenshot 2024-05-14 at 7 16 29 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) confirmation-redesign team-confirmations Push issues to confirmations team labels May 14, 2024
@jpuri jpuri requested review from a team as code owners May 14, 2024 13:48
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [ef625a2]
Page Load Metrics (1200 ± 740 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint751771173517
domContentLoaded107024157
load57377212001542740
domInteractive107024157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@digiwand
Copy link
Contributor

cc: @pedronfigueiredo for visibility

@jpuri jpuri merged commit a474aa3 into develop May 16, 2024
79 of 80 checks passed
@jpuri jpuri deleted the redesign_fix branch May 16, 2024 08:40
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 16, 2024
@metamaskbot metamaskbot added the release-11.18.0 Issue or pull request that will be included in release 11.18.0 label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@digiwand digiwand digiwand approved these changes

Assignees
No one assigned
Labels
confirmation-redesign release-11.18.0 Issue or pull request that will be included in release 11.18.0 team-confirmations Push issues to confirmations team
Projects
PR review queue
Archived in project
Milestone
No milestone
4 participants
@jpuri @metamaskbot @digiwand @pedronfigueiredo