Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Suggestion: Don't mess with sites that are already using dark mode. #376

Open
ethankuhrts opened this issue Feb 12, 2023 · 2 comments

Comments

@ethankuhrts
Copy link

Alot of modern websites already have a dark mode setting that turns on if either the browser has "prefers-color-scheme: dark" or they are just dark mode by default so midnight lizard isn't really needed with these and can even mess up some UI features.

Some big examples are:

  • Github: has a dark mode option that matches browser preferences.
  • Discord: dark mode by default, I've used midnight lizard with it and it drastically changes the UI
  • Youtube: has dark mode option that matches browser preference, midnight lizard makes thumbnails look muted and messes up UI a little bit

I'm sure there are thousands of examples of sites where midnight lizard is simply not needed.
So I suggest just adding something to detect if the website is already using dark mode and disable midnight lizard if it is.

Note: my experience is using the Edge browser, I am not certain whether it is the same

I will research this and to add these changes myself.

@dense-set
Copy link

You can add it to the whitelist: Simply deselect "Run on this website" under Activation.

@shaked8634
Copy link

+1 for this.
Not a FrontEnd dev but maybe it is possible somehow to calculate how many dark pixels are they and if above certain amount, not apply the Dark theme.

Awesome extension BTW :) (on Chrome)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants