Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sigill crash on Bitbucket pull requests view #381

Open
joser93 opened this issue Jun 20, 2023 · 3 comments
Open

Sigill crash on Bitbucket pull requests view #381

joser93 opened this issue Jun 20, 2023 · 3 comments

Comments

@joser93
Copy link

joser93 commented Jun 20, 2023

Hello.

I found an issue that might be interesting to check and probably a fix for other sites that are not bitbucket, a hint is that is fails on pages with loading screen because from the server side does certain processing, also, that view worked fine with the extension, so, maybe an update on the site or Chrome caused this.

Steps to reproduce:

  1. Open a bitbucket repository and create a branch with some changes
  2. Open branches view
  3. Press the create pull request from the view (make sure that dark mode is enabled before that)

Current behavior:
The view does not load properly and crashes with sigill error

Expected behavior:
The view should display with dark mode view

Additional tests:
Going back to step 2, disable dark mode and then press the create button for pull request, works and renders fine. But, on that view, if I re-enable dark mode, also crashes with sigill error code.

Tested on Google Chrome 114.0.5735.133

@pavel-agarkov
Copy link
Member

I would recommend excluding an address of the area where this bug is present in the Midnight Lizard settings:
image

@joser93
Copy link
Author

joser93 commented Jun 20, 2023

@pavel-agarkov thanks for the reply.

The pattern that worked for me is :

https://bitbucket.org/*/*/pull-requests/new
https://bitbucket.org/*/*/branches

If I don't include the branches view and reload the site, won't work, maybe because certain code still loaded if I don exclude and clean in that order?

Neither way, this workarround only avoids to apply dark mode on those pages and will be nice to have it fixed, there is a roadmap to address issues like this?

@pavel-agarkov
Copy link
Member

@joser93 not at the moment.
waiting for the world to become a more stable place to live...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants