Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - since I last pulled, base repo has test failures #158

Open
marksmayo opened this issue Nov 28, 2022 · 4 comments · May be fixed by #162
Open

BUG - since I last pulled, base repo has test failures #158

marksmayo opened this issue Nov 28, 2022 · 4 comments · May be fixed by #162
Labels
bug Something isn't working

Comments

@marksmayo
Copy link
Contributor

Describe the bug
Latest codebase, pulle down.
Run pytest
test_build.py is failing, and /schedule/test_core.py runs for 30 min and is still going?

I also tried running them all individually from vscode, got some more intermittent failures.

To Reproduce
Latest codebase, pulle down.
Run pytest

Expected behavior
Tests to execute in full and pass

Screenshots
image

image

Desktop (please complete the following information):

  • OS: Win 11
  • Python 3.11
  • pytest 2.15.6

Additional context
Test failure for build:

image

@marksmayo marksmayo added the bug Something isn't working label Nov 28, 2022
@Miksus
Copy link
Owner

Miksus commented Nov 28, 2022

Hmm, oh ye. Pass argument "--no-build" with the pytest call. Does that make it to go successfully? If not, I think you can ignore that 👍

I basically made that as a sanity check so that the package gets version dynamically when built (changed versioneer to setuptools_scm and the latter suggests to ignore _version.py). I'm not sure if that's no longer as necessary as every master merge goes to test PyPI anyways.

Perhaps I could change it the other way round: CI passes argument "--check-build" to Pytest and only then this sanity check test is run.

@Miksus Miksus linked a pull request Nov 29, 2022 that will close this issue
@marksmayo
Copy link
Contributor Author

pylint: error: Unrecognized option found: no-build - not for me, but I see you've done a PR to fix this so will take a look

@marksmayo
Copy link
Contributor Author

with new code, still getting:

image

but if it's ok to ignore I will for now

@Miksus
Copy link
Owner

Miksus commented Nov 30, 2022

Ye, you can ignore it 👍 I'm thinking of removing that test altogether, or at least remove the command-line argument. The reason for it was a sanity check the version is generated but I'm not sure if it's fruitful anymore test setuptools_scm itself works correctly.

The PR has issues with pytest. It seems you cannot pass arguments to pytest argparser in built packages without hacks. I possibly change the package layout a bit in the future by putting tests outside the library code but I'll inform well in advance if/when I'm doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants