Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG #219

Open
shushmentsev opened this issue Aug 29, 2023 · 5 comments
Open

BUG #219

shushmentsev opened this issue Aug 29, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@shushmentsev
Copy link

shushmentsev commented Aug 29, 2023

Can't start example from documentation!

Use "Rocketry" version 2.5.1, installed with "Poetry"
Error: raise PydanticUserError('const is removed, use Literal instead', code='removed-kwargs')

Screenshots
image
image

@shushmentsev shushmentsev added the bug Something isn't working label Aug 29, 2023
@Daniel-Ross
Copy link

I'm getting this error as well. Fresh install this morning.

@Jypear
Copy link

Jypear commented Aug 29, 2023

@profile-55 @Daniel-Ross
This is related to pydantic-v2 not being supported and no version tagging in the setup.py file as of yet.
#210

Forks do exist of Rocketry with pydantic.v1 shoe horned into the imports and a couple of PRs exist in fixing the overarching issue. But theres still ongoing work and Miksus is busy with other things at the moment.

If you need a quick fix, tie pydantic to v1.10.10 in your requirements.txt files and re-install pydantic in your venvs

pip uninstall pydantic
pip install pydantic==1.10.10

If you desperately need to use pydantic v2 (like with a requirement for another module you're using) then maybe take a look at one of the forks someone has done in the short term.

@MMartin09
Copy link

Is there any chance that this will be fixed in the near future?

@Jypear
Copy link

Jypear commented Sep 18, 2023

Is there any chance that this will be fixed in the near future?

@MMartin09 The blocker in this is the RedBird PR. Once thats finished then theres probably just some tweaks to do to the Rocketry PR. I just haven't really had time to look at the RedBird PR. Its quite difficult to migrate due to the variety of ways Pydantic has been used that aren't compatible with v2 and each issue requires a lot of digging to find an alternate solution.

I'm quite tied up with work so haven't really had time to look further and I expect I should be busy for another month or so. I'll try continue the PR when I can, but when its finished I'm not sure when Miksus will be around to review the PR. Probably not going to be a quick solution in the short term from my end.

@MMartin09
Copy link

Okay great. Thanks for the detailed answer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants