Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HuggingFace models (i.e. HuggingFaceCall) #215

Open
brenkao opened this issue May 7, 2024 · 1 comment
Open

Add support for HuggingFace models (i.e. HuggingFaceCall) #215

brenkao opened this issue May 7, 2024 · 1 comment
Labels
Feature Request New feature or request

Comments

@brenkao
Copy link
Collaborator

brenkao commented May 7, 2024

Is your feature request related to a problem? Please describe.
While HuggingFace is already supported through the OpenAICall class (use base_url, model, api_key="-"), we should support HuggingFace InferenceClient through a HuggingFaceCall class.

Describe the solution you'd like
Create a HugginFaceCall that extends BaseCall that follows same principles as other Calls. This means that call params are properly typed in a Pydantic model, responses extend BaseCallResponse, etc.

Additional context
See OpenAICall for reference.
https://github.com/Mirascope/mirascope/blob/dev/mirascope/openai/calls.py

@brenkao brenkao added Feature Request New feature or request good first issue Good for newcomers labels May 7, 2024
@willbakst willbakst changed the title Add new class HuggingFaceCall Feature Request: Add support for HuggingFace models (i.e. HuggingFaceCall) May 8, 2024
@willbakst willbakst changed the title Feature Request: Add support for HuggingFace models (i.e. HuggingFaceCall) [FEATURE REQUEST] Add support for HuggingFace models (i.e. HuggingFaceCall) May 8, 2024
@willbakst willbakst removed the good first issue Good for newcomers label May 8, 2024
@willbakst
Copy link
Contributor

The main thing on my mind for this feature is how this will interact with our prompt_template parsing. Will users want direct access to the underlying model prompt structure?

e.g. https://llama.meta.com/docs/model-cards-and-prompt-formats/meta-llama-3/

@willbakst willbakst changed the title [FEATURE REQUEST] Add support for HuggingFace models (i.e. HuggingFaceCall) Add support for HuggingFace models (i.e. HuggingFaceCall) May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants