Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High resolution options #117

Open
1 task done
MDMAchine opened this issue Jan 26, 2023 · 3 comments
Open
1 task done

High resolution options #117

MDMAchine opened this issue Jan 26, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@MDMAchine
Copy link

Running Latest Version

  • I am running the latest version

What do you want Mochi Diffusion to do?

While RealESRGAN is a common upscaler to use. I do like to have the option to utilize other models like BSRGAN for example.

Why do you think this should be added?

Theres a couple coreml versions here. They all render pretty quickly!

@MDMAchine MDMAchine added the enhancement New feature or request label Jan 26, 2023
@calben99
Copy link

Allowing Latent Upscaling would also be super useful!

@jrittvo
Copy link
Contributor

jrittvo commented Jun 19, 2023

Agree, but I'm not sure Apple's frameworks and libraries provide a way to work that directly with the latent space. Someone else who knows more than I do on this will hopefully give you a more definitive answer.

The BSRGAN module is ready to go. It is a drop-in replacement for the RealESRGAN that is used now, bu the UI needs a way to let the user select which to use, and that is on the to-do list.

@jrittvo
Copy link
Contributor

jrittvo commented Jul 17, 2023

@stuartjmoore offered to work on UI-centered upgrades. The heavy coding for this issue is already done, thanks to @vzsg with his build of BSRGAN that can directly substitute for the current RealESRGAN. (I renamed the BSRGAN file to RealESRGAN and copied it into the project, and it built and ran fine.)

So from here, implementing it means adding a new drop-down in Settings to let the user choose between the two upscalers (and maybe more in the future) and changing the actual code to allow the upscaler to be used to be set from the Settings. There is the question of whether this belongs here in Mochi or in ml-stable-diffusion, but I don't see the RealESRGAN model in their repo, so I assume it was added as part of assembling Mochi itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants