Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive model reloads when manipulating CN image #274

Open
1 task done
vzsg opened this issue Jul 6, 2023 · 4 comments
Open
1 task done

Excessive model reloads when manipulating CN image #274

vzsg opened this issue Jul 6, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@vzsg
Copy link
Contributor

vzsg commented Jul 6, 2023

Running Latest Version

  • I am running the latest version

Processor

M1 (or later)

Intel processor

No response

Memory

16GB

What happened?

  1. Select a CN-compatible model.
  2. Select a CN model.
  3. Press the X button for the CN image multiple times.
  4. Notice that the model is reloaded after every click, even though there is no real reason to do so.
image

There seems to be an unnecessary data dependency between the views and the ImageController.

Crash Log

No response

@vzsg vzsg added the bug Something isn't working label Jul 6, 2023
@jrittvo
Copy link
Contributor

jrittvo commented Jul 7, 2023

At least this can probably be fixed in just Mochi specific code. Someone just opened an issue about the python pipeline in ml-stable-diffusion over at that repo:

INFO: python_coreml_stable_diffusion.coreml_model: Loading a CoreML model through coremltools triggers compilation every time. The Swift package we provide uses precompiled Core ML models (.mlmodelc) to avoid compile-on-load.

@godly-devotion
Copy link
Collaborator

Yeah I did notice that. Also seems to happen when pressing Apply under Settings.

@jrittvo
Copy link
Contributor

jrittvo commented Jul 18, 2023

With something that was updated in one of the Swift files from ml-stable-diffusion 1.0.0 (that we now depend on) causing intermittent crashes when models load, eliminating these unnecessary reloads becomes even more of an issue . . .

@godly-devotion
Copy link
Collaborator

I misread the initial report. This hasn't been fixed yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants