Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Ability to control volume per-app #164

Open
Samuel12321 opened this issue Nov 2, 2020 · 17 comments
Open

Feature Request: Ability to control volume per-app #164

Samuel12321 opened this issue Nov 2, 2020 · 17 comments
Assignees
Labels
Enhancement New feature or request
Milestone

Comments

@Samuel12321
Copy link
Member

One of the most requested changes from store feedback is to add individual app volume control to ModernFlyouts.

@ShankarBUS
Copy link
Member

Woah! @Samuel12321, are you kidding me?

You do know it's very hard to do, don't you?

It will require intense work!

@Samuel12321
Copy link
Member Author

hence very low priority and post v1.0 labels.

A lot of the work has already been done by the ear trumpet team. But it is something to consider in the future when the app is out of preview.

@prakharb5
Copy link
Member

Is this really required? I mean, it's just a flyout, right?

@ShankarBUS
Copy link
Member

If it was just a flyout, I wouldn't have added new features to the GSMTC module.

LoL

@WindowsFanBoi, does this proposal somehow overlap with yours in #103?

@prakharb5
Copy link
Member

@ShankarBUS Aye Aye, captain!

Looks like it is overlapping.

@ShankarBUS
Copy link
Member

If the EarTrumpet devs look at this and #103, they'll kick our asses lol 😂.

Our plan should not be to replace EarTrumpet. We shouldn't disgrace their app this way. Let's give it the respect it deserves 😶.

@Samuel12321, Could you edit the title to say "Ability to control volume per-app"?

And in the detail we can say similar to EarTrumpet.

But we are gonna steal code from them anyways (if we were to implement this feature) 😂.

@prakharb5
Copy link
Member

Eartrumpet is anyways open source. No trademark there. Who will stop us?

@Samuel12321 Samuel12321 changed the title Feature Request: Integrate Eartrumpet functionality Feature Request: Ability to control volume per-app Nov 2, 2020
@Amit-Shan
Copy link

Perhaps a collaboration to integrate ear trumpet into modern flyout and vice versa? Not a developer, so apologies if that isn't possible and I am out of scope.

@ShankarBUS
Copy link
Member

EarTrumpet is stable, so they won't want to have any new breaking change. Even I asked them if I could add the media controls to their app as I have some experience on that.

File-New-Project/EarTrumpet#475

But they rejected my offer sedly 😢.

So, the only way is us integrating (stealing) features from EarTrumpet.

@Samuel12321
Copy link
Member Author

technically not stealing as Ear trumpet uses a MIT licence so we can use any of their code.
Ear trumpet seems to be not actively developed at the moment, last update was in February.

@prakharb5
Copy link
Member

prakharb5 commented Nov 3, 2020

Yeah, it seems to have fallen to a lull moment, for now. We can "borrow" code freely. 😁😁

@Amit-Shan
Copy link

Ha ha. Fair enough. Good luck!

@riverar
Copy link

riverar commented Dec 12, 2020

EarTrumpet dev here: We're more than happy to replace our flyout, but we have a lot of constraints (e.g. needs to be wpf, downlevel support, acrylic, have all the right accessibility, controls, high dpi, animations, etc.). Does ModernFlyouts support that?

@Samuel12321
Copy link
Member Author

Hi @riverar , ModernFlyouts is wpf, high dpi, has animations, and we are working on acrylic (@ShankarBUS has managed to find a way to add acrylic without the dragging lag #68).

We are open to adding/ accepting the addition of anything you felt nessesary.

@riverar we would be more than happy to add you as a collaborator if you wanted.

@ShankarBUS any thoughts/ anything you want to add.

@ShankarBUS
Copy link
Member

I'm just amazed! I'm too happy that they agreed to collaborate with us ❤️.

But downlevel support could be cut up to Windows 10 1809+ due to MSIX packaging.

Accessibility support needs further investigation. We need provide full accessibility support at least to the tray flyout.

Well, my acrylic method would restrict the minimum supported OS to Windows 10 1903 (due to Visual Layer dependency and reg free activation requirement).

Most of our existing user base are on Windows 10 1903+. So, I don't think this will block our path.

@Samuel12321
Copy link
Member Author

@FireCubeStudios came up with an interesting concept for this, which could be helpful for future flyout designs. For now the plan is to use this in a new tray flyout.
image

@Samuel12321 Samuel12321 added this to To do in 0.11 Release via automation Dec 27, 2021
@Samuel12321 Samuel12321 moved this from To do to In progress in 0.11 Release Dec 27, 2021
@rajeshbhavikatti
Copy link

rajeshbhavikatti commented Mar 31, 2022

Checkout Volumey it even has an option for custom hotkeys for each application well leaving that aside, looking forward for the update love to have this #164 (comment) volume flyout view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
0.11 Release
  
In progress
Development

No branches or pull requests

6 participants