Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More information about Aegis Libraries shoul be available #61

Open
Hyuchia opened this issue Jul 29, 2018 · 3 comments
Open

More information about Aegis Libraries shoul be available #61

Hyuchia opened this issue Jul 29, 2018 · 3 comments

Comments

@Hyuchia
Copy link
Member

Hyuchia commented Jul 29, 2018

Monogatari works internally with both Artemis and Kayros, however there is no information about them and thus no way for anyone to take advantage of them.

Artemis is pretty much a replacement for jQuery so Monogatari could ditch jQuery from the releases and also provides a lot of other functions that could be useful for anyone.

Kayros provides a CSS framework so people could take advantage of its grid and simple components.

@Amaimersion
Copy link
Contributor

As for me that was not a problem :D This frameworks is "well googled" and have a good documentation.

However, i (and others i think) will be very appreciate if you add a more documentation in the code. Key places is good documented for now, but many others places is not. Of course writing a large comments for obvious places or repeated places is not good practice at all. But if you add a small overview for all places, then it will be feels much more comfortable for contributors.

It is not a "must to do" work and it can waiting. After all, we're all consenting adults here and we can read through the code and use the debugger tool.

@Hyuchia
Copy link
Member Author

Hyuchia commented Jul 31, 2018

Ah yes, don't worry about that, the documentation this time will be there, right now I documented the main parts first but everything will be properly documented before releasing :) I know this has been a problem in pretty much all releases up to now so it's time for a change! I actually do consider this a "must" right now, I'd like for more people to contribute and for that, documentation is key :)

@Hyuchia Hyuchia added this to To do in Monogatari v2.0 Aug 1, 2018
@Hyuchia Hyuchia moved this from To do to In progress in Monogatari v2.0 Sep 2, 2018
@Hyuchia Hyuchia moved this from In progress to To do in Monogatari v2.0 Dec 1, 2018
@Hyuchia Hyuchia moved this from To do to Needs Design in Monogatari v2.0 Dec 10, 2018
@Hyuchia Hyuchia moved this from Needs Design to In progress in Monogatari v2.0 Mar 28, 2019
@LoganTann
Copy link
Contributor

UP.

If Aegis Libraries are well documented, the file Monogatari/dist/js/vendor/jquery.min.js should be deleted for the "stable" v2.0
If the user wants to use Jquery, he should import it himself instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Monogatari v2.0
  
In progress
Development

No branches or pull requests

3 participants