Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Loop doesn't work properly when 'Animate windows being resized' is enabled #355

Closed
2 tasks done
andrwmai opened this issue May 14, 2024 · 11 comments · Fixed by #360
Closed
2 tasks done

🐛 Loop doesn't work properly when 'Animate windows being resized' is enabled #355

andrwmai opened this issue May 14, 2024 · 11 comments · Fixed by #360
Assignees
Labels
bug Something isn't working

Comments

@andrwmai
Copy link

Bug Description

I use 2 screens, an external screen and the MacBook Pro's built-in screen. When 'Animate windows being resized' is enabled, I can't Loop within the built-in screen. If I Loop, it puts the window in my external screen (set as main display), and not even in the correct position.

I'm attaching a screen recording of this issue shown in my built-in screen. The first part of the recording shows the issue, and the rest shows the expected behavior when the feature is disabled.

Steps To Reproduce

  1. Enable 'Animate windows being resized'
  2. Try Looping in one of the screens, I'm assuming it happens to the one that's not set as the main display
  3. Watch it being resized/positioned in the main display instead and not the screen you want

Expected Behavior

Normal resizing/positioning like when the feature is disabled.

Actual Behavior

It puts the window in the wrong screen.

Screenshots

CleanShot.2024-05-15.at.12.19.51-converted.2.mp4

MacOS Version

Sonoma 14.5

Loop Version

1.0.0-beta.15

Additional Context

No response

Final Checks

  • My issue title is descriptive
  • This is a single bug (multiple bugs should be reported individually)
@andrwmai andrwmai added the bug Something isn't working label May 14, 2024
@MrKai77
Copy link
Owner

MrKai77 commented May 14, 2024

That's really weird.. and just to make sure, you can't reproduce this bug when the macbook's screen is set to the main display right?

@andrwmai
Copy link
Author

Yes, that's correct. If the built-in display is the main display then everything works totally fine. The gif below shows my external display and where the window goes to when looping in the built-in display with the feature enabled.

CleanShot 2024-05-15 at 2  50 23

@MrKai77
Copy link
Owner

MrKai77 commented May 16, 2024

Alright, that is a very weird bug. I will look into it!

@MrKai77 MrKai77 self-assigned this May 21, 2024
@andrwmai
Copy link
Author

Checking in to see if there's been any progress. :) And lmk if you need any testing I'm happy to help.

@MrKai77
Copy link
Owner

MrKai77 commented May 22, 2024

Yep, I've actually nearly done reworking window animations as a whole :D
I have posted a build here: #298 (comment)
Maybe that will already fix this issue?

@andrwmai
Copy link
Author

Just tested it and indeed it's fixed the issue of the window being moved to my external screen. However, the behavior isn't the same. Before when I selected a window in my external screen, and with my cursor in my MacBook screen, the window moved to my MacBook screen when I looped, now it only moves to the screen where it's at even when my cursor is on another screen. I think the previous behavior is more convenient in some circumstances.

@PKizzle
Copy link

PKizzle commented May 23, 2024

Maybe let users decide which behavior they prefer using a setting?

@MrKai77
Copy link
Owner

MrKai77 commented May 23, 2024

Yes, that is currently being tracked on #251, where I am planning to make it configurable :)

@andrwmai
Copy link
Author

Yes! Is there a development build that we can test? :)

Also, I'm super excited for the new UI update!

@MrKai77
Copy link
Owner

MrKai77 commented May 24, 2024

Not yet.. it's still missing a few things :)
But you can follow its development on #361!

@MrKai77
Copy link
Owner

MrKai77 commented May 24, 2024

I'll also be closing this issue since it seems to have been fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants